Add wred drop probability config in qos wred profile#1913
Closed
wendani wants to merge 2 commits intosonic-net:masterfrom
Closed
Add wred drop probability config in qos wred profile#1913wendani wants to merge 2 commits intosonic-net:masterfrom
wendani wants to merge 2 commits intosonic-net:masterfrom
Conversation
Signed-off-by: Wenda <wenni@microsoft.com>
yxieca
approved these changes
Aug 10, 2018
yxieca
requested changes
Aug 10, 2018
Contributor
yxieca
left a comment
yxieca
left a comment
There was a problem hiding this comment.
Looks like you need to fix the test too. Maybe consider using the default value approach?
What is the downside if we don't config them?
Signed-off-by: Wenda <wenni@microsoft.com>
Contributor
Author
|
It will use the hardware default drop probability 0% |
Collaborator
|
commented on the other pr in swss, we do not need this if we keep the default value in swss to be 100. |
andriymoroz-mlnx
approved these changes
Aug 10, 2018
vivekrnv
added a commit
to vivekrnv/sonic-buildimage
that referenced
this pull request
Nov 23, 2021
a0bff26 [acl-loader] modify acl-loader with change in STATE DB ACL capability table (sonic-net#1896) a395e28 [debug dump util] Changes for EVPN and VxLAN dump module (sonic-net#1892) 02a98ef [debug dump util] Route Module added (sonic-net#1913) ac8382f [generic-config-updater] Logging change just before applying it (sonic-net#1934) 9ab6c51 [flex counter] Flex counter threads consume too much CPU resources. sonic-net#9202 (sonic-net#1925) 2ec47a5 [generic-config-updater] Handling empty tables while sorting a patch (sonic-net#1923) fdedcbf [fdbshow]: Handle FDB cleanup gracefully. (sonic-net#1926) e7535ae [sonic-cli-gen] first phase implementation of the SONiC CLI Auto-generation tool (sonic-net#1644) Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
5 tasks
lguohan
pushed a commit
that referenced
this pull request
Nov 24, 2021
a0bff26 [acl-loader] modify acl-loader with change in STATE DB ACL capability table (#1896) a395e28 [debug dump util] Changes for EVPN and VxLAN dump module (#1892) 02a98ef [debug dump util] Route Module added (#1913) ac8382f [generic-config-updater] Logging change just before applying it (#1934) 9ab6c51 [flex counter] Flex counter threads consume too much CPU resources. #9202 (#1925) 2ec47a5 [generic-config-updater] Handling empty tables while sorting a patch (#1923) fdedcbf [fdbshow]: Handle FDB cleanup gracefully. (#1926) e7535ae [sonic-cli-gen] first phase implementation of the SONiC CLI Auto-generation tool (#1644) Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
taras-keryk
pushed a commit
to taras-keryk/sonic-buildimage
that referenced
this pull request
Apr 28, 2022
* Added the Route Module to the Debug Dump Utility Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wenda wenni@microsoft.com
- What I did
- How I did it
- How to verify it
Tested on one brcm dut with sonic-net/sonic-swss#571
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)