[Nokia-7215] Enhance Watchdog service#18850
Merged
yxieca merged 1 commit intosonic-net:masterfrom Jun 5, 2024
Merged
Conversation
11 tasks
prgeor
reviewed
May 3, 2024
platform/marvell/sonic-platform-nokia/7215/service/cpu_wdt.service
Outdated
Show resolved
Hide resolved
saiarcot895
reviewed
May 14, 2024
platform/marvell/sonic-platform-nokia/debian/sonic-platform-nokia-7215.postinst
Outdated
Show resolved
Hide resolved
f918bc9 to
f8adf12
Compare
f8adf12 to
9519679
Compare
saiarcot895
reviewed
May 31, 2024
Contributor
There was a problem hiding this comment.
Is this guaranteed to happen before watchdog-control.service starts? If there's a chance it could be after, then add --now to have systemd stop the service as well.
Contributor
Author
There was a problem hiding this comment.
I have verified all scenarios to make sure there is no race condition - fresh install, software upgrade, reboots. The watchdog-control.service is always masked correctly and the platform watchdog is active.
I have added the --now flag as recommended. I agree this is good to have in case something changes in the future
Mask Watchdog-control.service and make sure only one watchdog service starts on this platform
9519679 to
20af2dd
Compare
saiarcot895
approved these changes
Jun 2, 2024
Contributor
Author
Contributor
|
@bingwang-ms to tracking 202405 cherry-picking |
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Jun 6, 2024
Mask Watchdog-control.service and make sure only one watchdog service starts on this platform
Collaborator
|
Cherry-pick PR to 202405: #19236 |
mssonicbld
pushed a commit
that referenced
this pull request
Jun 6, 2024
Mask Watchdog-control.service and make sure only one watchdog service starts on this platform
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mask Watchdog-control.service and make sure only one watchdog service starts on this platform
Why I did it
To resolve conflict between ordering of the 2 watchdog services.
Is some cases service 1 was started after service 2 leaving the watchdog on the box disabled
Work item tracking
How I did it
Enhance service file to assure cpu_wdt.service always starts after watchdog-control.service
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)