Skip to content

[Mellanox] Fix 4600c sensors.conf inverted psu number designation #18722

Merged
liat-grozovik merged 1 commit intosonic-net:masterfrom
yuazhe:fix_sensors_conf
May 21, 2024
Merged

[Mellanox] Fix 4600c sensors.conf inverted psu number designation #18722
liat-grozovik merged 1 commit intosonic-net:masterfrom
yuazhe:fix_sensors_conf

Conversation

@yuazhe
Copy link
Copy Markdown
Contributor

@yuazhe yuazhe commented Apr 19, 2024

Why I did it

This PR is used to standardize several sensors.conf psu section
I. Fix 4600/4600c inverted psu number designation
II. Fix 5600 second psu miss set_power_cap label
III. Standardized comments

Work item tracking
  • Microsoft ADO (number only):

How I did it

How to verify it

check sensors command output

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

  • 202311

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@yuazhe yuazhe force-pushed the fix_sensors_conf branch from 5854853 to 196bd0e Compare April 19, 2024 01:54
@yuazhe yuazhe changed the title [Mellanox] standardizing the sensors.conf psu section [Mellanox] Fix 4600c sensors.conf psu section inverted designation Apr 19, 2024
@yuazhe yuazhe changed the title [Mellanox] Fix 4600c sensors.conf psu section inverted designation [Mellanox] Fix 4600c sensors.conf inverted psu number designation Apr 19, 2024
@keboliu keboliu self-requested a review April 19, 2024 02:04
@yuazhe yuazhe marked this pull request as ready for review April 19, 2024 05:58
@yuazhe
Copy link
Copy Markdown
Contributor Author

yuazhe commented Apr 24, 2024

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Copy Markdown
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

I.   Fix 4600/4600c psu number inverted issue
II.  Fix 5600 second psu missing set_power_cap label
III. Standardized comments

Signed-off-by: Yuanzhe, Liu <[email protected]>
@yuazhe yuazhe force-pushed the fix_sensors_conf branch from 196bd0e to e60f858 Compare April 26, 2024 02:35
@keboliu keboliu requested a review from prgeor May 10, 2024 07:48
@yuazhe
Copy link
Copy Markdown
Contributor Author

yuazhe commented May 21, 2024

/azpw ms_conflict

@liat-grozovik
Copy link
Copy Markdown
Collaborator

@yuazhe please check if this also needed for 202305

@liat-grozovik liat-grozovik merged commit bf556c5 into sonic-net:master May 21, 2024
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request May 23, 2024
…nic-net#18722)

- Why I did it
This PR is used to standardize several sensors.conf psu section
I. Fix 4600/4600c inverted psu number designation
II. Fix 5600 second psu miss set_power_cap label
III. Standardized comments

- How to verify it
check sensors command output

Signed-off-by: Yuanzhe, Liu <[email protected]>
@mssonicbld
Copy link
Copy Markdown
Collaborator

Cherry-pick PR to 202311: #19054

mssonicbld pushed a commit that referenced this pull request May 23, 2024
…8722)

- Why I did it
This PR is used to standardize several sensors.conf psu section
I. Fix 4600/4600c inverted psu number designation
II. Fix 5600 second psu miss set_power_cap label
III. Standardized comments

- How to verify it
check sensors command output

Signed-off-by: Yuanzhe, Liu <[email protected]>
@yuazhe
Copy link
Copy Markdown
Contributor Author

yuazhe commented Jul 11, 2024

@yxieca please help to approve this pr for 202305

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants