Skip to content

Adds YANG models for configurable intervals in CONFIG_DB for stormond#18657

Merged
qiluo-msft merged 10 commits intosonic-net:masterfrom
ashwnsri:storagemond-polling-interval-configdb
May 22, 2024
Merged

Adds YANG models for configurable intervals in CONFIG_DB for stormond#18657
qiluo-msft merged 10 commits intosonic-net:masterfrom
ashwnsri:storagemond-polling-interval-configdb

Conversation

@ashwnsri
Copy link
Copy Markdown
Contributor

@ashwnsri ashwnsri commented Apr 11, 2024

Why I did it

This is part of a larger feature: SONiC Storage Monitoring Daemon -- this commit adds the option to configure the daemon's polling interval and fsstats file sync interval (in seconds) of the daemon via config_db by introducing YANG models.

Work item tracking
  • Microsoft ADO (number only): 17468992

How I did it

Gives userside the option to dynamically a new table 'STORMOND' with key INTERVALS and fields 'daemon_polling_interval' with default value of '3600' seconds and 'fsstats_sync_interval' with default value of '86400' seconds as defined in the YANG model.

How to verify it

Flash image onto a DUT and add the aforementioned table to the CONFIG_DB. Verify that stormond has picked up your config intervals.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@ashwnsri ashwnsri changed the title Added configurable polling interval to storagemond Adds configurable intervals for stormond to CONFIG_DB May 7, 2024
@ashwnsri ashwnsri marked this pull request as ready for review May 7, 2024 23:45
@ashwnsri ashwnsri requested a review from lguohan as a code owner May 7, 2024 23:45
@ashwnsri ashwnsri requested a review from qiluo-msft as a code owner May 8, 2024 22:20
@ashwnsri ashwnsri force-pushed the storagemond-polling-interval-configdb branch from db30e91 to fc44000 Compare May 9, 2024 04:07
@ganglyu
Copy link
Copy Markdown
Contributor

ganglyu commented May 9, 2024

Please update doc/Configuration.md

Copy link
Copy Markdown
Contributor

@wen587 wen587 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ashwnsri ashwnsri changed the title Adds configurable intervals for stormond to CONFIG_DB Adds YANG models for configurable intervals in CONFIG_DB for stormond May 16, 2024
prgeor
prgeor previously approved these changes May 17, 2024
qiluo-msft
qiluo-msft previously approved these changes May 20, 2024
@ashwnsri
Copy link
Copy Markdown
Contributor Author

Please update doc/Configuration.md

Done

@ganglyu
Copy link
Copy Markdown
Contributor

ganglyu commented May 20, 2024

Please update tests/files/sample_config_db.json

@ashwnsri ashwnsri force-pushed the storagemond-polling-interval-configdb branch from 4fbbcdc to cd23667 Compare May 20, 2024 23:19
Copy link
Copy Markdown
Contributor

@ganglyu ganglyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prgeor
Copy link
Copy Markdown
Contributor

prgeor commented May 21, 2024

@assrinivasan please fix the build and errors

@ashwnsri
Copy link
Copy Markdown
Contributor Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Copy Markdown
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@qiluo-msft qiluo-msft merged commit 8db0a1f into sonic-net:master May 22, 2024
@wen587
Copy link
Copy Markdown
Contributor

wen587 commented Sep 28, 2025

Hi @ashwnsri , I added this yang to image build in setup.py. Just make sure the missing is not intentional.
#24010

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants