Skip to content

Fix for sonic-config-engine build failure - test_buffers_dell6100_render_template #18566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
krismarvell wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix for sonic-config-engine build failure - test_buffers_dell6100_render_template #18566

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions slave.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -927,6 +927,9 @@ $(addprefix $(PYTHON_WHEELS_PATH)/, $(SONIC_PYTHON_WHEELS)) : $(PYTHON_WHEELS_PA
# Load the target deb from DPKG cache
$(call LOAD_CACHE,$*,$@)

# unset PLATFORM Flag for python wheel generation
PLATFORM=
export PLATFORM
Copy link
Copy Markdown
Contributor

@saiarcot895 saiarcot895 Apr 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to have this be applied early in slave.mk, so that it applies for all builds, not just Python wheels?

Copy link
Copy Markdown
Contributor Author

@krismarvell krismarvell Apr 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like anywhere else unsetting this outside specific targets, have the effect of globally changing the flag even for "make configure" as well. Hence have added only in the specific python wheel targets where this is hitting into the error.

# Skip building the target if it is already loaded from cache
if [ -z '$($*_CACHE_LOADED)' ] ; then

Expand Down