[dhcp_server] Adjust the dhcp_server cli data format to align with dhcp_cfggen#18519
Merged
yxieca merged 10 commits intosonic-net:masterfrom Apr 16, 2024
Merged
[dhcp_server] Adjust the dhcp_server cli data format to align with dhcp_cfggen#18519yxieca merged 10 commits intosonic-net:masterfrom
yxieca merged 10 commits intosonic-net:masterfrom
Conversation
w1nda
requested review from
Xichen96 and
yaqiangz
and removed request for
lguohan
Blueve
reviewed
Apr 8, 2024
yaqiangz
approved these changes
Apr 9, 2024
This comment was marked as outdated.
This comment was marked as outdated.
yaqiangz
approved these changes
Apr 12, 2024
Member
Author
|
Hi @yxieca , cloud you help merge this PR? thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
dhcp_server cli using string while dhcp_cfggen using array of string, I need to align them.
Work item tracking
How I did it
Add magic character @ to make sure string will be interpreted to array of string.
How to verify it
Unit test.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)