[Nokia-7220 IXR] Add support for NOKIA 7220 IXR-H3, H4-32D, H5-64D platforms by fzhou-nokia · Pull Request #18497 · sonic-net/sonic-buildimage

fzhou-nokia · 2024-03-28T15:55:53Z

Why I did it

Add support for NOKIA 7220 IXR-H3, NOKIA 7220-IXR-H4-32D & 7220-IXR-H5-64D platforms:

NOKIA 7220-IXR-H3:
Platform: x86_64-nokia_ixr7220_h3-r0
HwSKU: Nokia-IXR7220-H3
ASIC: Broadcom
Port Config: 32x400G + 2x10G

NOKIA 7220-IXR-H4-32D:
Platform: x86_64-nokia_ixr7220_h4_32d-r0
HwSKU: Nokia-IXR7220-H4-32D
ASIC: Broadcom
Port Config: 32x400G + 1x10G

NOKIA 7220-IXR-H5-64D:
Platform: x86_64-nokia_ixr7220_h5_64d-r0
HwSKU: Nokia-IXR7220-H5-64D
ASIC: Broadcom
Port Config: 64x400G + 2x10G

Work item tracking

Microsoft ADO (number only):

How I did it

Added module for each platform under ../device/nokia directory.
Modified the platform/broadcom/one-image.mk to include each PLATFORM_MODULE
Modified the platform/broadcom/ platform-modules-nokia.mk to include each platform
Add platform related directory ixr7220h3, ixr7220h4-32d and ixr7220h5-64d in platform/Broadcom/sonic-platform-modules-nokia
Modified related build scripts in platform/Broadcom/sonic-platform-modules-nokia/debian

How to verify it

Make sure the sonic-buildimage is successful
Run this image on x86_64-nokia_ixr7220_h3-r0 and verify all dockers are up and test basic commands like:
o show version
o show platform summary
o show platform syseeprom
o show platform fan
o show platform psustatus
o show platform firmware status
o show platform temperature
o sudo show system-health detail
o show interface status
Run OC test, for T0/T1 topology and have 100% pass on platform.
Run this image on x86_64-nokia_ixr7250e_sup-r0 and x86_64-nokia_ixr7250e_36x400g-r0, make sure all functions run correctly.

Which release branch to backport (provide reason below if selected)

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

fzhou-nokia · 2024-03-28T19:05:42Z

@Pavan-Nokia @jon-nokia @mlok-nokia Please help review

jon-nokia · 2024-03-28T19:16:40Z

device/nokia/x86_64-nokia_ixr7220_h3-r0/plugins/led_control.py

In general, we should not commit untested and/or commented out code. Save this for some other commit.

Thanks! I update it with 661c78b

liushilongbuaa · 2024-04-01T10:01:14Z

/azpw ms_conflict

mssonicbld · 2024-04-01T10:09:27Z

@StormLiangMS,@liushilongbuaa PR: #18497 is conflict with MS internal repo
Please push fix commit to sonicbld/precheck/head/18497 and approve
https://msazure.visualstudio.com/One/_git/Networking-acs-buildimage/pullrequest/9811366
After ms PR is merged, comment "/azpw ms_conflict" to rerun PR checker.

Pavan-Nokia · 2024-04-03T14:49:26Z

@StormLiangMS,@liushilongbuaa PR: #18497 is conflict with MS internal repoPlease push fix commit to sonicbld/precheck/head/18497 and approvehttps://msazure.visualstudio.com/One/_git/Networking-acs-buildimage/pullrequest/9811366After ms PR is merged, comment "/azpw ms_conflict" to rerun PR checker.

@liushilongbuaa @StormLiangMS Can you please take a look at this

liushilongbuaa · 2024-04-07T08:16:53Z

/azpw ms_conflict

mssonicbld · 2024-04-07T08:28:34Z

@StormLiangMS,@liushilongbuaa PR: #18497 is conflict with MS internal repo
Please push fix commit to sonicbld/precheck/head/18497 and approve
https://msazure.visualstudio.com/One/_git/Networking-acs-buildimage/pullrequest/9852302
After ms PR is merged, comment "/azpw ms_conflict" to rerun PR checker.

liushilongbuaa · 2024-04-07T09:08:00Z

/azpw ms_conflict

Pavan-Nokia · 2024-04-15T13:10:11Z

@liushilongbuaa @mssonicbld How can we help resolve this "internal conflict" issue and get this PR merged.

liushilongbuaa · 2024-04-16T05:17:29Z

@liushilongbuaa @mssonicbld How can we help resolve this "internal conflict" issue and get this PR merged.

It is resolved last week.

Pavan-Nokia · 2024-04-16T12:21:47Z

@liushilongbuaa @mssonicbld How can we help resolve this "internal conflict" issue and get this PR merged.

It is resolved last week.

I still see that the corresponding PR check is in pending state and has not completed.
Do you recommend we restart the checks?

fzhou-nokia · 2024-04-16T13:30:47Z

/azpw run Azure.sonic-buildimage

mssonicbld · 2024-04-16T13:30:50Z

/AzurePipelines run Azure.sonic-buildimage

azure-pipelines · 2024-04-16T13:31:00Z

Azure Pipelines successfully started running 1 pipeline(s).

fzhou-nokia · 2024-04-16T20:05:08Z

/azpw run Azure.sonic-buildimage

mssonicbld · 2024-04-16T20:05:11Z

/AzurePipelines run Azure.sonic-buildimage

azure-pipelines · 2024-04-16T20:05:24Z

Azure Pipelines successfully started running 1 pipeline(s).

fzhou-nokia · 2024-04-18T12:59:36Z

/azpw run Azure.sonic-buildimage

mssonicbld · 2024-04-18T12:59:39Z

/AzurePipelines run Azure.sonic-buildimage

azure-pipelines · 2024-04-18T12:59:51Z

Azure Pipelines successfully started running 1 pipeline(s).

Blueve · 2024-04-22T13:06:33Z

Run this image on x86_64-nokia_ixr7250e_sup-r0 and x86_64-nokia_ixr7250e_36x400g-r0, make sure all functions run correctly.

Why you state that you tested on 7250?

fzhou-nokia · 2024-04-22T13:23:18Z

Run this image on x86_64-nokia_ixr7250e_sup-r0 and x86_64-nokia_ixr7250e_36x400g-r0, make sure all functions run correctly.

Why you state that you tested on 7250?

The H3 and 7250 share build files, so we have tested and made sure that our changes have not caused any regression to already existing platforms.

Pavan-Nokia · 2024-05-06T12:20:38Z

@Blueve @yxieca Please help merge

yxieca · 2024-05-13T17:42:02Z

@prgeor can you help review this PR?

Add support for NOKIA 7220 IXR-H3: Platform: x86_64-nokia_ixr7220_h3-r0 HwSKU: Nokia-IXR7220-H3 ASIC: Broadcom Port Config: 32x400G + 2x10G

update pmon link

…H4-32D and 7220 IXR-H5-64D platforms

Pavan-Nokia · 2024-05-17T17:20:08Z

@liushilongbuaa After we rebased the PR to latest Master the internal conflict (ms_conflict) has appeared again.
Could you please help resolve.

liushilongbuaa · 2024-05-20T07:52:38Z

@liushilongbuaa After we rebased the PR to latest Master the internal conflict (ms_conflict) has appeared again. Could you please help resolve.

We are fixing the conflict. It still needs about 12 hours for the automation.

Pavan-Nokia · 2024-05-21T12:57:42Z

@liushilongbuaa After we rebased the PR to latest Master the internal conflict (ms_conflict) has appeared again. Could you please help resolve.

We are fixing the conflict. It still needs about 12 hours for the automation.

@liushilongbuaa Thank you for your help with this.
Are we all set to retry the PR checks?

liushilongbuaa · 2024-05-22T03:54:34Z

/azpw ms_conflict

Pavan-Nokia · 2024-05-22T12:40:20Z

@yxieca Please help merge
Thank you

fzhou-nokia force-pushed the dev_h3 branch from c6ff6f2 to a334904 Compare March 28, 2024 16:29

fzhou-nokia marked this pull request as ready for review March 28, 2024 19:04

fzhou-nokia requested a review from lguohan as a code owner March 28, 2024 19:04

jon-nokia reviewed Mar 28, 2024

View reviewed changes

fzhou-nokia force-pushed the dev_h3 branch from 93da17e to 661c78b Compare March 29, 2024 18:40

fzhou-nokia force-pushed the dev_h3 branch from 661c78b to d4820b8 Compare April 17, 2024 15:55

yxieca requested a review from prgeor May 13, 2024 17:41

fzhou-nokia added 4 commits May 16, 2024 19:28

[Nokia-7220-H3] Add support for NOKIA 7220 IXR-H3 platform

6389734

Add support for NOKIA 7220 IXR-H3: Platform: x86_64-nokia_ixr7220_h3-r0 HwSKU: Nokia-IXR7220-H3 ASIC: Broadcom Port Config: 32x400G + 2x10G

[Nokia-7220-H3] Add support for NOKIA 7220 IXR-H3 platform

bd7f34a

update pmon link

Remove untested code

0526fe9

[Nokia-7220-H4-32D][Nokia-7220-H5-64D]Add support for NOKIA 7220 IXR-…

9cf0ebc

…H4-32D and 7220 IXR-H5-64D platforms

fzhou-nokia force-pushed the dev_h3 branch from d4820b8 to 9cf0ebc Compare May 16, 2024 19:28

fzhou-nokia changed the title ~~[Nokia-7220-H3] Add support for NOKIA 7220 IXR-H3 platform~~ [Nokia-7220 IXR] Add support for NOKIA 7220 IXR-H3, H4-32D, H5-64D platforms May 16, 2024

prgeor approved these changes May 17, 2024

View reviewed changes

yxieca merged commit 3acd509 into sonic-net:master May 23, 2024

fzhou-nokia deleted the dev_h3 branch May 23, 2024 17:28

gechiang mentioned this pull request Jun 6, 2024

Update Nokia PMON submodule #18938

Closed

11 tasks

Conversation

fzhou-nokia commented Mar 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why I did it

Work item tracking

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Uh oh!

fzhou-nokia commented Mar 28, 2024

Uh oh!

jon-nokia Mar 28, 2024

Choose a reason for hiding this comment

Uh oh!

fzhou-nokia Mar 29, 2024

Choose a reason for hiding this comment

Uh oh!

liushilongbuaa commented Apr 1, 2024

Uh oh!

mssonicbld commented Apr 1, 2024

Uh oh!

Pavan-Nokia commented Apr 3, 2024

Uh oh!

liushilongbuaa commented Apr 7, 2024

Uh oh!

mssonicbld commented Apr 7, 2024

Uh oh!

liushilongbuaa commented Apr 7, 2024

Uh oh!

Pavan-Nokia commented Apr 15, 2024

Uh oh!

liushilongbuaa commented Apr 16, 2024

Uh oh!

Pavan-Nokia commented Apr 16, 2024

Uh oh!

fzhou-nokia commented Apr 16, 2024

Uh oh!

mssonicbld commented Apr 16, 2024

Uh oh!

azure-pipelines bot commented Apr 16, 2024

Uh oh!

fzhou-nokia commented Apr 16, 2024

Uh oh!

mssonicbld commented Apr 16, 2024

Uh oh!

azure-pipelines bot commented Apr 16, 2024

Uh oh!

fzhou-nokia commented Apr 18, 2024

Uh oh!

mssonicbld commented Apr 18, 2024

Uh oh!

azure-pipelines bot commented Apr 18, 2024

Uh oh!

Blueve commented Apr 22, 2024

Uh oh!

fzhou-nokia commented Apr 22, 2024

Uh oh!

Pavan-Nokia commented May 6, 2024

Uh oh!

yxieca commented May 13, 2024

Uh oh!

Pavan-Nokia commented May 17, 2024

Uh oh!

liushilongbuaa commented May 20, 2024

Uh oh!

Pavan-Nokia commented May 21, 2024

Uh oh!

liushilongbuaa commented May 22, 2024

Uh oh!

Pavan-Nokia commented May 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

fzhou-nokia commented Mar 28, 2024 •

edited

Loading