[device/dell] Update Shared headroom values#1846
Merged
yxieca merged 1 commit intosonic-net:masterfrom Jul 10, 2018
Merged
Conversation
This commit updates the shared headroom value for z9100 T0 and T1 profile based on the ratio. The ratio is derived from the 40G broadcom recommended XL Sheet. Unit tested the above configuration by dumping the registers for the shared headroom. The shared headroom values in registers reflects the correct new values for both T1 and T0. Signed-off-by: Harish Venkatraman <[email protected]>
Contributor
Author
|
@yxieca Can you please review the changes. These are the shared headroom changes which was agreed on the last call. |
yxieca
approved these changes
Jul 10, 2018
taras-keryk
pushed a commit
to taras-keryk/sonic-buildimage
that referenced
this pull request
Apr 28, 2022
What I did These format are not wrong. But if error_handler for $? is installed, these places would cause fase positives. How I did it Update more bash syntax to avoid false positives How to verify it Run show tech support test before merge. Signed-off-by: Ying Xie [email protected]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates the shared headroom value for z9100
T0 and T1 profile based on the ratio. The ratio is derived
from the 40G broadcom recommended XL Sheet.
Unit tested the above configuration by dumping the registers
for the shared headroom. The shared headroom values in registers
reflects the correct new values for both T1 and T0.
Signed-off-by: Harish Venkatraman [email protected]
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)