[containercfgd] Add multi ASIC support for syslog rate limit feature#18438
Merged
liat-grozovik merged 2 commits intosonic-net:masterfrom Apr 15, 2024
Merged
Conversation
keboliu
approved these changes
Apr 1, 2024
Junchao-Mellanox
changed the title
saiarcot895
approved these changes
Apr 10, 2024
liat-grozovik
approved these changes
Apr 14, 2024
Collaborator
|
@Junchao-Mellanox is there any dependency between this one and the PR in utilities? |
Collaborator
Author
|
Hi Liat, there is no dependency. We can merge this one first. |
Collaborator
Author
|
Hi @yxieca , could you please help cherry-pick? |
Contributor
|
@Junchao-Mellanox can this feature wait for 202405 branch? |
Collaborator
Author
I am ok with it. @saiarcot895 , what do you think? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
For multi asic platform, the container name is not the same as service name. For example, service name swss, the container in namespace asic0 will have container name swss0. This PR is to support multi ASIC platform.
Work item tracking
How I did it
Add a global variable service_name and use it to match DB key.
How to verify it
Manual test
Unit test
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)