[Fixbug 18418] [Yang] MACSEC_PROFILE table does not match yang definition#18419
Merged
qiluo-msft merged 1 commit intosonic-net:masterfrom Mar 21, 2024
Merged
[Fixbug 18418] [Yang] MACSEC_PROFILE table does not match yang definition#18419qiluo-msft merged 1 commit intosonic-net:masterfrom
qiluo-msft merged 1 commit intosonic-net:masterfrom
Conversation
Signed-off-by: Ze Gan <[email protected]>
Pterosaur
changed the title
ganglyu
approved these changes
Mar 21, 2024
judyjoseph
approved these changes
Mar 21, 2024
Contributor
|
hi @Pterosaur what's the impact to miss this one for 202305? could you update the ADO? |
Contributor
Author
@StormLiangMS ADO is: 24657445 |
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
May 9, 2024
…tion (sonic-net#18419) ### Why I did it Fix the issue [18418](sonic-net#18418), The YANG model to MACsec fallback cak/ckn is wrong. We should allow the fallback option is empty. ### How I did it Add a condition to check whether the fallback is providered #### How to verify it Check Azp
Collaborator
|
Cherry-pick PR to 202305: #18918 |
mssonicbld
added
Included in 202305 Branch
and removed
Created PR to 202305 Branch
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Fix the issue 18418, The YANG model to MACsec fallback cak/ckn is wrong. We should allow the fallback option is empty.
Work item tracking
How I did it
Add a condition to check whether the fallback is providered
How to verify it
Check Azp
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)