[E1031] Bugfix for Python syntax error in sonic_platform/common.py#18380
Closed
lizhijianrd wants to merge 1 commit intosonic-net:masterfrom
Closed
[E1031] Bugfix for Python syntax error in sonic_platform/common.py#18380lizhijianrd wants to merge 1 commit intosonic-net:masterfrom
lizhijianrd wants to merge 1 commit intosonic-net:masterfrom
Conversation
Blueve
approved these changes
Mar 17, 2024
Contributor
Author
|
/azpw run Azure.sonic-buildimage |
Collaborator
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
Closing this PR due to PR test issue. |
Contributor
Author
|
Current PR test failed due to DPU testcase issue which cannot be resolve by retry. Opened new PR #18386 to re-trigger PR test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Bugfix for Python syntax error in sonic_platform/common.py.
A method of class need to have
selfas parameter.Fixing below issue:
Work item tracking
How I did it
Add
selfparameter to functionCommon::is_host().How to verify it
Verified on E1031 DUT with this patch.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)