Add pre-emphasis for 100G optical mocule#1838
Merged
yxieca merged 1 commit intosonic-net:201803from Jul 4, 2018
Merged
Conversation
|
|
yxieca
approved these changes
Jul 3, 2018
dgsudharsan
pushed a commit
to dgsudharsan/sonic-buildimage
that referenced
this pull request
Dec 16, 2025
<!-- Please make sure you've read and understood our contributing guidelines: https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md failure_prs.log Make sure all your commits include a signature generated with `git commit -s` ** If this is a bug fix, make sure your description includes "fixes #xxxx", or "closes #xxxx" or "resolves #xxxx" Please provide the following information: --> #### Why I did it 1. Existing systemd script has issue in triggering kubectl for restarting container service, because telemetry systemd service is launched via admin user, which cannot access to kubectl related config file and cert. 2. container_checker has issue in triggering kubectl for filter running_container to append the container rollouted via kubernetes, change the implementation logic to fix it ##### Work item tracking - Microsoft ADO **(number only)**: #### How I did it 1. Change telemetry.service to be run by root user. 2. Use sidecar container to overwrite /lib/systemd/system/telemetry.service. so that kubectl could be triggered in systemd script, which is used for container restart via pod grep/delete. 4. Change container_checker logic to add more container into running_containers set, the container rollouted via kubernetes has io.kubernetes.pod.namespace=sonic, this change is to make sure monit can still return succeed for periodical FEATURE table and running container check. #### How to verify it Verified on testbed. <img width="2108" height="682" alt="image" src="https://github.com/user-attachments/assets/a511b327-d071-4360-b06e-529adbde3270" /> <img width="2090" height="856" alt="image" src="https://github.com/user-attachments/assets/832af05f-0fe9-482f-9d79-27a3b989f3cf" /> <!-- If PR needs to be backported, then the PR must be tested against the base branch and the earliest backport release branch and provide tested image version on these two branches. For example, if the PR is requested for master, 202211 and 202012, then the requester needs to provide test results on master and 202012. --> #### Which release branch to backport (provide reason below if selected) <!-- - Note we only backport fixes to a release branch, *not* features! - Please also provide a reason for the backporting below. - e.g. - [x] 202006 --> - [ ] 202205 - [ ] 202211 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [ ] 202505 #### Tested branch (Please provide the tested image version) <!-- - Please provide tested image version - e.g. - [x] 20201231.100 --> - [ ] <!-- image version 1 --> - [ ] <!-- image version 2 --> #### Description for the changelog <!-- Write a short (one line) summary that describes the changes in this pull request for inclusion in the changelog: --> <!-- Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU. --> #### Link to config_db schema for YANG module changes <!-- Provide a link to config_db schema for the table for which YANG model is defined Link should point to correct section on https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md --> #### A picture of a cute animal (not mandatory but encouraged)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)