[minigraph-parser] Update UT to avoid race condition during build image#18321
Merged
yxieca merged 1 commit intosonic-net:masterfrom Mar 12, 2024
Merged
Conversation
lizhijianrd
changed the title
Blueve
approved these changes
Mar 11, 2024
liushilongbuaa
approved these changes
Mar 12, 2024
Contributor
Author
|
Hi @yxieca , can you please help to merge this PR? |
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Mar 12, 2024
Collaborator
|
Cherry-pick PR to 202311: #18346 |
mssonicbld
pushed a commit
that referenced
this pull request
Mar 15, 2024
mssonicbld
added
Included in 202311 Branch
and removed
Created PR to 202311 Branch
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Fix issue #18180.
I suspect this issue caused by race condition during building SONiC image. Some UT cases of minigraph-parser missed
port_config_path. Hence the testcases will rely on methoddevice_info.get_path_to_port_config_fileinsonic-py-commonto read port config info. As multiple components in SONiC are built in parallel, that method may not finish built when it's called by UT.Work item tracking
How I did it
Transfer value to param
port_config_pathwhen calling functionparse_xmlin UT. Then the UT will not rely onsonic-py-common.How to verify it
Verified by PR test.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)