[dhcp_server] add config dhcp server option#18013
Merged
yxieca merged 20 commits intosonic-net:masterfrom Feb 22, 2024
Merged
Conversation
yaqiangz
reviewed
Feb 4, 2024
| @clicommon.pass_db | ||
| def dhcp_server_ipv4_option_add(db, option_name, option_id, type_, value): | ||
| ctx = click.get_current_context() | ||
| if not validate_str_type("uint32", option_id): |
Contributor
There was a problem hiding this comment.
option id is uint8 rather than uint32. And currently we only support customizing unassigned options, which refer to https://github.com/sonic-net/sonic-buildimage/blob/master/src/sonic-dhcp-utilities/dhcp_utilities/dhcpservd/dhcp_option.csv
yaqiangz
reviewed
Feb 4, 2024
| if not validate_str_type("uint32", option_id): | ||
| ctx.fail("option_id must be uint32") | ||
| if type_ != "string": | ||
| ctx.fail("Currently only string type is supported") |
Contributor
There was a problem hiding this comment.
Supported type:
yaqiangz
approved these changes
Feb 4, 2024
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
Contributor
Author
|
@yxieca Hi Ying, please help take a look |
yxieca
reviewed
Feb 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add config dhcp_server option cli.
Why I did it
Add config dhcp_server option cli.
Work item tracking
How I did it
Add function to config plugin
How to verify it
Run unittests
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Add config dhcp_server option cli
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)