Skip to content

Don't create a pty to run vtysh inside of the docker container #1792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pavel-shirshov merged 1 commit into from
Jun 14, 2018
Merged

Don't create a pty to run vtysh inside of the docker container #1792

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions dockers/docker-fpm-frr/base_image_files/vtysh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
#!/bin/bash

DOCKER_EXEC_FLAGS="i"

# Determine whether stdout is on a terminal
if [ -t 1 ] ; then
DOCKER_EXEC_FLAGS+="t"
fi

docker exec -$DOCKER_EXEC_FLAGS bgp vtysh "$@"
docker exec -i bgp vtysh "$@"
9 changes: 1 addition & 8 deletions dockers/docker-fpm-quagga/base_image_files/vtysh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
#!/bin/bash

DOCKER_EXEC_FLAGS="i"

# Determine whether stdout is on a terminal
if [ -t 1 ] ; then
DOCKER_EXEC_FLAGS+="t"
fi

docker exec -$DOCKER_EXEC_FLAGS bgp vtysh "$@"
docker exec -i bgp vtysh "$@"