Skip to content

[yang] Support ASIC/SDK health event#17879

Merged
kperumalbfn merged 8 commits intosonic-net:masterfrom
stephenxs:asic-sdk-health-event
May 7, 2024
Merged

[yang] Support ASIC/SDK health event#17879
kperumalbfn merged 8 commits intosonic-net:masterfrom
stephenxs:asic-sdk-health-event

Conversation

@stephenxs
Copy link
Collaborator

@stephenxs stephenxs commented Jan 23, 2024 •
edited by liat-grozovik
Loading

Why I did it

Support ASIC/SDK health event: yang model update

  • Suppress ASIC/SDK health event configuration
  • New event
Work item tracking
  • Microsoft ADO (number only):

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@stephenxs stephenxs mentioned this pull request Jan 23, 2024
Merged
@stephenxs
Support ASIC/SDK health event
00ea737 
- Suppress ASIC/SDK health event configuration
- New event

Signed-off-by: Stephen Sun <[email protected]>
@stephenxs
Minor changes
67143d5 
1. Add SAI timestamp in event
2. Adjust multi ASIC representation

Signed-off-by: Stephen Sun <[email protected]>
@stephenxs
Update documentation
90c18de 
Signed-off-by: Stephen Sun <[email protected]>
@stephenxs
Address community review comments
9d5406d 
Eliminate oldest events if the number of events exceed the threshold

Signed-off-by: Stephen Sun <[email protected]>
@stephenxs stephenxs force-pushed the asic-sdk-health-event branch from bcc233a to 9d5406d Compare February 2, 2024 03:35
@stephenxs stephenxs marked this pull request as ready for review March 14, 2024 09:44
@stephenxs stephenxs requested a review from qiluo-msft as a code owner March 14, 2024 09:44
@lguohan lguohan added the YANG YANG model related changes label Mar 30, 2024
@liat-grozovik
Copy link
Collaborator

liat-grozovik commented Apr 16, 2024

@qiluo-msft @dgsudharsan can you please help to review the PR?

@stephenxs
Copy link
Collaborator Author

stephenxs commented Apr 18, 2024

Seems to be a dependency issue.
The sonic-yang-mgmt test depends on the latest sonic-yang-model in this PR. But at the time when the sonic-yang-mgmt test was running the latest sonic-yang-model python wheel had not been installed.
Trying to find a quick way to resolve the dependency issue for now but if there isn't I would like to move sample_config_db.json into another PR depending on this one.

@stephenxs
Fix compiling issue
d6565e2 
Signed-off-by: Stephen Sun <[email protected]>
@stephenxs
Copy link
Collaborator Author

stephenxs commented Apr 19, 2024 •
edited
Loading

Seems to be a dependency issue. The sonic-yang-mgmt test depends on the latest sonic-yang-model in this PR. But at the time when the sonic-yang-mgmt test was running the latest sonic-yang-model python wheel had not been installed. Trying to find a quick way to resolve the dependency issue for now but if there isn't I would like to move sample_config_db.json into another PR depending on this one.

Fixed. It was because the new yang model file was not listed in setup.py.

@stephenxs
Copy link
Collaborator Author

stephenxs commented Apr 30, 2024

@qiluo-msft @prsunny Could you help to review and merge the PR? This is the yang model of ASIC/SDK health event. Thanks.

@stephenxs stephenxs mentioned this pull request May 3, 2024
Merged
@bingwang-ms
Copy link
Contributor

bingwang-ms commented May 6, 2024

@kperumalbfn @prabhataravind Can you please help review this change?

@liat-grozovik
Copy link
Collaborator

liat-grozovik commented May 7, 2024

@zhangyanzhao @qiluo-msft could you please help to approve it on the coming yang meeting? if not, i suggest to merge it as we need it for 202405.

@liat-grozovik liat-grozovik changed the title Support ASIC/SDK health event [yang] Support ASIC/SDK health event May 7, 2024
@prsunny
Copy link
Contributor

prsunny commented May 7, 2024

@kperumalbfn , please merge once you signoff. Yang change is approved by Sudharsan.

@kperumalbfn kperumalbfn merged commit bbf4b86 into sonic-net:master May 7, 2024
@stephenxs stephenxs deleted the asic-sdk-health-event branch May 7, 2024 22:21
qiluo-msft pushed a commit to sonic-net/sonic-utilities that referenced this pull request May 13, 2024
@stephenxs
Support ASIC/SDK health event (#3129)
8629b68 
#### What I did

Support ASIC/SDK health event
1. config asic-sdk-health-event suppress
2. show asic-sdk-health-event [received|suppress]
3. sonic-clear asic-sdk-health-event

Depends on sonic-net/sonic-buildimage#17879

#### How to verify it

Unit test
arfeigin pushed a commit to arfeigin/sonic-utilities that referenced this pull request Jun 16, 2024
@stephenxs @arfeigin
Support ASIC/SDK health event (sonic-net#3129)
7f84136 
#### What I did

Support ASIC/SDK health event
1. config asic-sdk-health-event suppress
2. show asic-sdk-health-event [received|suppress]
3. sonic-clear asic-sdk-health-event

Depends on sonic-net/sonic-buildimage#17879

#### How to verify it

Unit test
nmoray pushed a commit to nmoray/sonic-utilities that referenced this pull request Jun 25, 2025
@stephenxs @nmoray
Support ASIC/SDK health event (sonic-net#3129)
f60078a 
#### What I did

Support ASIC/SDK health event
1. config asic-sdk-health-event suppress
2. show asic-sdk-health-event [received|suppress]
3. sonic-clear asic-sdk-health-event

Depends on sonic-net/sonic-buildimage#17879

#### How to verify it

Unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dgsudharsan dgsudharsan dgsudharsan approved these changes

@prsunny prsunny prsunny approved these changes

@kperumalbfn kperumalbfn kperumalbfn approved these changes

@Junchao-Mellanox Junchao-Mellanox Junchao-Mellanox approved these changes

@qiluo-msft qiluo-msft Awaiting requested review from qiluo-msft qiluo-msft is a code owner

Assignees

No one assigned

Labels

YANG YANG model related changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@stephenxs @liat-grozovik @bingwang-ms @prsunny @dgsudharsan @kperumalbfn @Junchao-Mellanox @lguohan