Skip to content

Revert the feature: serial port watchdog service#1766

Merged
qiluo-msft merged 2 commits intosonic-net:masterfrom
qiluo-msft:qiluo/revertserial
Jun 5, 2018
Merged

Revert the feature: serial port watchdog service#1766
qiluo-msft merged 2 commits intosonic-net:masterfrom
qiluo-msft:qiluo/revertserial

Conversation

@qiluo-msft
Copy link
Copy Markdown
Collaborator

@qiluo-msft qiluo-msft commented Jun 5, 2018

This feature breaks continous_reboot test on both Mellanox and Broadcom platforms

@qiluo-msft qiluo-msft merged commit eee3671 into sonic-net:master Jun 5, 2018
@qiluo-msft qiluo-msft deleted the qiluo/revertserial branch June 5, 2018 04:07
lguohan pushed a commit that referenced this pull request Jun 5, 2018
* Revert "[serial watchdog] remove serial watchdog service dependency to rc.local (#1752)"
* Revert "[service] introducing serial port watchdog service (#1743)"
@lguohan lguohan mentioned this pull request Aug 17, 2021
5 tasks
lguohan added a commit to lguohan/sonic-buildimage that referenced this pull request Aug 17, 2021
* 0a145e8 2021-08-17 | Revert "[config][generic-update] Implementing patch sorting (sonic-net#1599)" (HEAD, origin/master, origin/HEAD) [Guohan Lu]
* dbcc6fd 2021-08-16 | [config reload]: fix the condition for checking if system is starting (sonic-net#1766) (HEAD, origin/master, origin/HEAD) [Guohan Lu]
* 2c7cfaa 2021-08-17 | [sonic-package-manager] switch from poetry-semver to semantic_version due to bugs found in poetry-semver (sonic-net#1710) [Stepan Blyshchak]
* 7821a3f 2021-08-13 | [vnet_route_check] don't hardcode prefix length of /24 (sonic-net#1756) [Stepan Blyshchak]
* 4175cb9 2021-08-11 | [show priority-group drop counters] Add user info output when user want to check PG counters and polling are disabled (sonic-net#1678) [Andriy Yurkiv]
* 920bb87 2021-08-10 | [config][generic-update] Implementing patch sorting (sonic-net#1599) [Mohamed Ghoneim]
* 30907c4 2021-08-06 | [config][interface][speed] Fixed the config interface speed in multiasic issue (sonic-net#1739) [Marty Y. Lok]
* 4b88e0e 2021-08-06 | [minigraph] Donot enable PFC watchdog for MgmtTsToR (sonic-net#1734) [Blueve]

Signed-off-by: Guohan Lu <[email protected]>
lguohan added a commit that referenced this pull request Aug 17, 2021
* 0a145e8 2021-08-17 | Revert "[config][generic-update] Implementing patch sorting (#1599)" (HEAD, origin/master, origin/HEAD) [Guohan Lu]
* dbcc6fd 2021-08-16 | [config reload]: fix the condition for checking if system is starting (#1766) (HEAD, origin/master, origin/HEAD) [Guohan Lu]
* 2c7cfaa 2021-08-17 | [sonic-package-manager] switch from poetry-semver to semantic_version due to bugs found in poetry-semver (#1710) [Stepan Blyshchak]
* 7821a3f 2021-08-13 | [vnet_route_check] don't hardcode prefix length of /24 (#1756) [Stepan Blyshchak]
* 4175cb9 2021-08-11 | [show priority-group drop counters] Add user info output when user want to check PG counters and polling are disabled (#1678) [Andriy Yurkiv]
* 920bb87 2021-08-10 | [config][generic-update] Implementing patch sorting (#1599) [Mohamed Ghoneim]
* 30907c4 2021-08-06 | [config][interface][speed] Fixed the config interface speed in multiasic issue (#1739) [Marty Y. Lok]
* 4b88e0e 2021-08-06 | [minigraph] Donot enable PFC watchdog for MgmtTsToR (#1734) [Blueve]

Signed-off-by: Guohan Lu <[email protected]>
qiluo-msft pushed a commit that referenced this pull request Jan 19, 2022
includes:

320591a [DualToR] Handle race condition between tunnel_decap and mux orchestrator (#2114)
5027a8f Handling Invalid CRM configuration gracefully (#2109)
0b120fa [ci]: use native arm64 and armhf pool (#2013)
394e88a Don't handle buffer pool watermark during warm reboot reconciling (#1987)
9008a01 patch for issue #1971 - enable Rx Drop handling for cisco-8000 (#2041)
2723ee3 create debug_shell_enable config to enable debug shell (#2060)
d7be0b9 [request parser] Add unit tests for request parser for multiple values (#1766)
theasianpianist pushed a commit to theasianpianist/sonic-buildimage that referenced this pull request Feb 5, 2022
sonic-net#1766)

What I did
Add unit tests for request parser to parse multiple values.

Why I did it
Add unit tests for the feature added in PR sonic-net#1758.

How I verified it
Run unit tests locally and confirm the tests pass with the given conditions and constraints.
taras-keryk pushed a commit to taras-keryk/sonic-buildimage that referenced this pull request Apr 28, 2022
…sonic-net#1766)

When systemd services finished, the systemd status could running
or degraded. Therefore, compare system status with starting directly.

Here is what is happening on kvm switch. Some services cannot be started.
Then, the system state is in degraded state.

```
admin@ARISTA01T1:~$ systemctl is-system-running
starting
admin@ARISTA01T1:~$ systemctl is-system-running
degraded
```

Signed-off-by: Guohan Lu <[email protected]>
mssonicbld added a commit that referenced this pull request Feb 14, 2026
…tically (#25435)

#### Why I did it
src/sonic-sairedis
```
* 5e421441 - (HEAD -> master, origin/master, origin/HEAD) Add .github/copilot-instructions.md for AI-assisted development (#1764) (2 days ago) [rustiqly]
* d482f261 - [test] Fix flaky FlexCounter.bulkChunksize by replacing usleep with poll-wait (#1766) (2 days ago) [rustiqly]
* 6f062102 - Use get_stats_ext instead of get_stats for switch counters (#1757) (3 days ago) [Ryan Garofano]
```
#### How I did it
#### How to verify it
#### Description for the changelog
FengPan-Frank pushed a commit to FengPan-Frank/sonic-buildimage that referenced this pull request Mar 6, 2026
…tically (sonic-net#25435)

#### Why I did it
src/sonic-sairedis
```
* 5e421441 - (HEAD -> master, origin/master, origin/HEAD) Add .github/copilot-instructions.md for AI-assisted development (sonic-net#1764) (2 days ago) [rustiqly]
* d482f261 - [test] Fix flaky FlexCounter.bulkChunksize by replacing usleep with poll-wait (sonic-net#1766) (2 days ago) [rustiqly]
* 6f062102 - Use get_stats_ext instead of get_stats for switch counters (sonic-net#1757) (3 days ago) [Ryan Garofano]
```
#### How I did it
#### How to verify it
#### Description for the changelog

Signed-off-by: Feng Pan <[email protected]>
dprital pushed a commit that referenced this pull request Mar 19, 2026
…tically (#25435)

#### Why I did it
src/sonic-sairedis
```
* 5e421441 - (HEAD -> master, origin/master, origin/HEAD) Add .github/copilot-instructions.md for AI-assisted development (#1764) (2 days ago) [rustiqly]
* d482f261 - [test] Fix flaky FlexCounter.bulkChunksize by replacing usleep with poll-wait (#1766) (2 days ago) [rustiqly]
* 6f062102 - Use get_stats_ext instead of get_stats for switch counters (#1757) (3 days ago) [Ryan Garofano]
```
#### How I did it
#### How to verify it
#### Description for the changelog

Signed-off-by: dprital <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants