[FRR] Force disable next hop group support#17344
Merged
StormLiangMS merged 1 commit intosonic-net:masterfrom Dec 6, 2023
Merged
[FRR] Force disable next hop group support#17344StormLiangMS merged 1 commit intosonic-net:masterfrom
StormLiangMS merged 1 commit intosonic-net:masterfrom
Conversation
Signed-off-by: Nazarii Hnydyn <[email protected]>
nazariig
requested review from
liat-grozovik,
prsunny,
qiluo-msft,
stepanblyschak and
volodymyrsamotiy
dgsudharsan
approved these changes
Nov 29, 2023
liat-grozovik
changed the title
Collaborator
|
@StormLiangMS Can you please review and signoff |
Collaborator
|
Tested on top of 202305 commit https://github.com/sonic-net/sonic-buildimage/tree/c8750621779aaa847c1dc1672a48d467071298a6 |
Contributor
|
hi @nazariig @dgsudharsan could you help to elaborate what's the cons to disable FRR next hop group support? |
Collaborator
I believe there is no cons. If the NOS is using the nexthop group, it will affect performance. However SONiC is not using nexthop group today. Hence there is no impact with respect to SONiC |
prsunny
approved these changes
Dec 4, 2023
Contributor
|
Please wait for @StormLiangMS's approval |
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Dec 6, 2023
Signed-off-by: Nazarii Hnydyn [email protected] Closes sonic-net#17345 This W/A was proposed by Nvidia FRR team before the long term solution is ready. Why I did it A W/A to fix default route installation during LAG member flap Work item tracking N/A How I did it Disabled FRR next hop group support How to verify it Do LAG member flap
Collaborator
|
Cherry-pick PR to 202305: #17423 |
11 tasks
mssonicbld
added a commit
that referenced
this pull request
Dec 6, 2023
mssonicbld
added
Included in 202305 Branch
and removed
Created PR to 202305 Branch
labels
Contributor
|
Hi @yxieca, can you please help to add "Approved for 202311 Branch" tag to this PR? thanks. |
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Jan 17, 2024
Signed-off-by: Nazarii Hnydyn [email protected] Closes sonic-net#17345 This W/A was proposed by Nvidia FRR team before the long term solution is ready. Why I did it A W/A to fix default route installation during LAG member flap Work item tracking N/A How I did it Disabled FRR next hop group support How to verify it Do LAG member flap
Collaborator
|
Cherry-pick PR to 202311: #17804 |
11 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Jan 18, 2024
Signed-off-by: Nazarii Hnydyn [email protected] Closes #17345 This W/A was proposed by Nvidia FRR team before the long term solution is ready. Why I did it A W/A to fix default route installation during LAG member flap Work item tracking N/A How I did it Disabled FRR next hop group support How to verify it Do LAG member flap
mssonicbld
added
Included in 202311 Branch
and removed
Created PR to 202311 Branch
labels
dgsudharsan
added a commit
to dgsudharsan/sonic-buildimage
that referenced
this pull request
Apr 18, 2024
This reverts commit 1ff27db.
dgsudharsan
added a commit
to dgsudharsan/sonic-buildimage
that referenced
this pull request
May 13, 2024
This reverts commit 1ff27db.
11 tasks
lipxu
pushed a commit
to lipxu/sonic-buildimage
that referenced
this pull request
Jul 10, 2025
Signed-off-by: Nazarii Hnydyn [email protected] Closes sonic-net#17345 This W/A was proposed by Nvidia FRR team before the long term solution is ready. Why I did it A W/A to fix default route installation during LAG member flap Work item tracking N/A How I did it Disabled FRR next hop group support How to verify it Do LAG member flap
lipxu
pushed a commit
to lipxu/sonic-buildimage
that referenced
this pull request
Jul 10, 2025
Signed-off-by: Nazarii Hnydyn [email protected] Closes sonic-net#17345 This W/A was proposed by Nvidia FRR team before the long term solution is ready. Why I did it A W/A to fix default route installation during LAG member flap Work item tracking N/A How I did it Disabled FRR next hop group support How to verify it Do LAG member flap
bingwang-ms
pushed a commit
that referenced
this pull request
Jul 15, 2025
* [frr]: Force disable next hop group support. (#17344) Signed-off-by: Nazarii Hnydyn [email protected] Closes #17345 This W/A was proposed by Nvidia FRR team before the long term solution is ready. Why I did it A W/A to fix default route installation during LAG member flap Work item tracking N/A How I did it Disabled FRR next hop group support How to verify it Do LAG member flap * for dualtor * for UT --------- Co-authored-by: Nazarii Hnydyn <[email protected]>
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nazarii Hnydyn [email protected]
Closes #17345
This W/A was proposed by Nvidia FRR team before the long term solution is ready.
Why I did it
Work item tracking
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)