Moving get_routing_stack() to a centralized location to avoid code dups#1714
Merged
lguohan merged 2 commits intosonic-net:masterfrom Aug 7, 2018
Merged
Conversation
…plication Various areas of sonic-utilities are now demanding this functionality so i'm simply moving this routing to a centralized location. After spending some time debating about the ideal location for this function, we thought about sonic-config-engine/sonic_platform.py as the closest match. Functional tests' output will be provided as part of the equivalent PR to be submitted shortly within sonic-utilities repo.
Contributor
Author
|
Changes in this PR are connected to those ones in PR/254.. The 'get_routing_stack()' function is being brought from 'sonic-utilities/show/main.py'. |
jleveque
approved these changes
May 16, 2018
nikos-github
suggested changes
May 17, 2018
| mac = mac[:-2] + aligned_last_byte | ||
| return mac | ||
|
|
||
| def get_system_routing_stack(): |
Collaborator
There was a problem hiding this comment.
This is a file that is meant to retrieve platform specific related information from config files. Doesn't seem the python function you are introducing belongs here and it will be best placed in utilities. Ultimately sonic MS team is to bless this.
Contributor
There was a problem hiding this comment.
It may not be the perfect fit, but it's probably the best centralized location we currently have. It's better than sonic-utilities, as that repo houses command-line utilities.
In the future, I'd like to see sonic_platform.py, minigraph.py, openconfig_acl.py and portconfig.py moved out of sonic-config-engine and built into a new package, separate from sonic-cfggen. They are modules which are imported by sonic-cfggen, but can also be imported into other scripts. At that point, we could create a separate module for this function because it's technically not platform-specific. Until then, I think this is fine.
Maybe a comment should be added stating that the function is not platform-specific and may be better moved to a new module in the future?
Contributor
Author
There was a problem hiding this comment.
Right, this is what i meant in my original PR comment -- there's no ideal location for this function, but it definitely has to be outside sonic-utilities as various submodules are/will-be in need of this feature. I'll add a comment as Joe suggested.
And as previously discussed (Joe), we should definitely move all this generic functionality outside sonic-buildimage superproject -- a new repo with no configuration-specific semantics should be hosting all this system/generic functionality.
Contributor
There was a problem hiding this comment.
Agree with Joe's comment that ideally all those library functions should be moved into a separate module in the future. I also understand that by now here might be the best place that hosts generic-purpose functions. However, as this function really differs from others in sonic_platform.py - all existing functions there are to read hardware-specific information that remain constant for a specific device, while this added function is about container information, which might be affected by operation.
How about creating a new python file hosting all docker-related lib functions? I'm sure we'll need more such facilities when we come back to revisit the container upgrade scenario.
Contributor
Author
Contributor
There was a problem hiding this comment.
I think a file in the current folder will do. How about a name like "sonic_component.py"?
Contributor
Author
|
@taoyl-ms, could you please review? Thanks. |
Collaborator
|
retest this please |
qiluo-msft
reviewed
Jun 23, 2018
| # suitable location is identified as part of upcoming refactoring efforts. | ||
| # | ||
| def get_system_routing_stack(): | ||
| command = "sudo docker ps | grep bgp | awk '{print$2}' | cut -d'-' -f3 | cut -d':' -f1" |
Collaborator
There was a problem hiding this comment.
ps | grep [](start = 27, length = 9)
pgrep
4 tasks
volodymyrsamotiy
added a commit
to volodymyrsamotiy/sonic-buildimage
that referenced
this pull request
May 28, 2021
dad1287 [tunneldecaporch] Set default MTU for the overlay loopback interface (sonic-net#1756) 1bc94d1 [orchagent] Fix typo in PortsOrch::initPortSupportedSpeeds (sonic-net#1755) a44e651 [nhg]: Add support for weight in nexthop group member. (sonic-net#1752) 5c625b2 [Bulk mode] Limit the size of bulker (sonic-net#1744) d1cd0fd Fix error msg due to not supported "SAI_SWITCH_ATTR_MAX_NUMBER_OF_TEMP_SENSORS" attributes (sonic-net#1745) 278770d [sub intf] Fix kernel side processing to enslave sub interface to non-default vrf (sonic-net#1521) 031f536 support flush FDB entries per port and per vlan (sonic-net#1064) 3629d70 [sonic-swss] Add port auto negotiation support to swss (sonic-net#1714) 7c6ebb1 [fix] Use the same storm detection condition for queue occupancy non-zero case as the zero case (sonic-net#1111) fb06c32 [fabricportsorch] Add fabric support (sonic-net#1459) Signed-off-by: Volodymyr Samotiy <volodymyrs@nvidia.com>
4 tasks
4 tasks
liat-grozovik
pushed a commit
that referenced
this pull request
May 31, 2021
dad1287 [tunneldecaporch] Set default MTU for the overlay loopback interface (#1756) 1bc94d1 [orchagent] Fix typo in PortsOrch::initPortSupportedSpeeds (#1755) a44e651 [nhg]: Add support for weight in nexthop group member. (#1752) 5c625b2 [Bulk mode] Limit the size of bulker (#1744) d1cd0fd Fix error msg due to not supported "SAI_SWITCH_ATTR_MAX_NUMBER_OF_TEMP_SENSORS" attributes (#1745) 278770d [sub intf] Fix kernel side processing to enslave sub interface to non-default vrf (#1521) 031f536 support flush FDB entries per port and per vlan (#1064) 3629d70 [sonic-swss] Add port auto negotiation support to swss (#1714) 7c6ebb1 [fix] Use the same storm detection condition for queue occupancy non-zero case as the zero case (#1111) fb06c32 [fabricportsorch] Add fabric support (#1459) Signed-off-by: Volodymyr Samotiy <volodymyrs@nvidia.com>
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
dad1287 [tunneldecaporch] Set default MTU for the overlay loopback interface (sonic-net#1756) 1bc94d1 [orchagent] Fix typo in PortsOrch::initPortSupportedSpeeds (sonic-net#1755) a44e651 [nhg]: Add support for weight in nexthop group member. (sonic-net#1752) 5c625b2 [Bulk mode] Limit the size of bulker (sonic-net#1744) d1cd0fd Fix error msg due to not supported "SAI_SWITCH_ATTR_MAX_NUMBER_OF_TEMP_SENSORS" attributes (sonic-net#1745) 278770d [sub intf] Fix kernel side processing to enslave sub interface to non-default vrf (sonic-net#1521) 031f536 support flush FDB entries per port and per vlan (sonic-net#1064) 3629d70 [sonic-swss] Add port auto negotiation support to swss (sonic-net#1714) 7c6ebb1 [fix] Use the same storm detection condition for queue occupancy non-zero case as the zero case (sonic-net#1111) fb06c32 [fabricportsorch] Add fabric support (sonic-net#1459) Signed-off-by: Volodymyr Samotiy <volodymyrs@nvidia.com>
theasianpianist
pushed a commit
to theasianpianist/sonic-buildimage
that referenced
this pull request
Feb 5, 2022
1. Added port auto negotiation attributes handle 2. Get supported speeds for each port and save them to CONFIG_DB 3. Added new test cases in VS test to verify the change
noaOrMlnx
pushed a commit
to noaOrMlnx/sonic-buildimage
that referenced
this pull request
Oct 26, 2025
…tomatically (sonic-net#1714) #### Why I did it src/sonic-gnmi ``` * 070d104 - (HEAD -> 202412, origin/202412) Refactor show arp and show ndp with common FDB data (sonic-net#134) (14 hours ago) [Deepak-Pandey] ``` #### How I did it #### How to verify it #### Description for the changelog
mssonicbld
added a commit
that referenced
this pull request
Dec 16, 2025
…tically (#24791) #### Why I did it src/sonic-sairedis ``` * 1bf99980 - (HEAD -> master, origin/master, origin/HEAD) changes for vpp release 202510 (#1695) (3 days ago) [aronovic] * 0ecbb5b9 - Revert "[meta] do not fail bulk operations if MODE_IGNORE_ERROR (#1613)" (#1676) (3 days ago) [Nikola Dancejic] * 3ab2f07d - Graceful shutdown vpp to avoid core dump (#1714) (4 days ago) [yue-fred-gao] * a5e0e632 - Revert "Temp workaround for sonic-buildimage issue 23387 (#1629)" (#1700) (4 days ago) [Ze Gan] * b735b473 - Use sonic build pool for building sairedis (#1719) (5 days ago) [Saikrishna Arcot] ``` #### How I did it #### How to verify it #### Description for the changelog
hdwhdw
pushed a commit
to hdwhdw/sonic-buildimage
that referenced
this pull request
Dec 18, 2025
…tically (sonic-net#24791) #### Why I did it src/sonic-sairedis ``` * 1bf99980 - (HEAD -> master, origin/master, origin/HEAD) changes for vpp release 202510 (sonic-net#1695) (3 days ago) [aronovic] * 0ecbb5b9 - Revert "[meta] do not fail bulk operations if MODE_IGNORE_ERROR (sonic-net#1613)" (sonic-net#1676) (3 days ago) [Nikola Dancejic] * 3ab2f07d - Graceful shutdown vpp to avoid core dump (sonic-net#1714) (4 days ago) [yue-fred-gao] * a5e0e632 - Revert "Temp workaround for sonic-buildimage issue 23387 (sonic-net#1629)" (sonic-net#1700) (4 days ago) [Ze Gan] * b735b473 - Use sonic build pool for building sairedis (sonic-net#1719) (5 days ago) [Saikrishna Arcot] ``` #### How I did it #### How to verify it #### Description for the changelog Signed-off-by: Dawei Huang <daweihuang@microsoft.com>
xwjiang-ms
pushed a commit
to xwjiang-ms/sonic-buildimage
that referenced
this pull request
Dec 22, 2025
…tically (sonic-net#24791) #### Why I did it src/sonic-sairedis ``` * 1bf99980 - (HEAD -> master, origin/master, origin/HEAD) changes for vpp release 202510 (sonic-net#1695) (3 days ago) [aronovic] * 0ecbb5b9 - Revert "[meta] do not fail bulk operations if MODE_IGNORE_ERROR (sonic-net#1613)" (sonic-net#1676) (3 days ago) [Nikola Dancejic] * 3ab2f07d - Graceful shutdown vpp to avoid core dump (sonic-net#1714) (4 days ago) [yue-fred-gao] * a5e0e632 - Revert "Temp workaround for sonic-buildimage issue 23387 (sonic-net#1629)" (sonic-net#1700) (4 days ago) [Ze Gan] * b735b473 - Use sonic build pool for building sairedis (sonic-net#1719) (5 days ago) [Saikrishna Arcot] ``` #### How I did it #### How to verify it #### Description for the changelog Signed-off-by: xiaweijiang <xiaweijiang@microsoft.com>
jasonbridges
pushed a commit
to jasonbridges/sonic-buildimage
that referenced
this pull request
Jan 22, 2026
…tically (sonic-net#24791) #### Why I did it src/sonic-sairedis ``` * 1bf99980 - (HEAD -> master, origin/master, origin/HEAD) changes for vpp release 202510 (sonic-net#1695) (3 days ago) [aronovic] * 0ecbb5b9 - Revert "[meta] do not fail bulk operations if MODE_IGNORE_ERROR (sonic-net#1613)" (sonic-net#1676) (3 days ago) [Nikola Dancejic] * 3ab2f07d - Graceful shutdown vpp to avoid core dump (sonic-net#1714) (4 days ago) [yue-fred-gao] * a5e0e632 - Revert "Temp workaround for sonic-buildimage issue 23387 (sonic-net#1629)" (sonic-net#1700) (4 days ago) [Ze Gan] * b735b473 - Use sonic build pool for building sairedis (sonic-net#1719) (5 days ago) [Saikrishna Arcot] ``` #### How I did it #### How to verify it #### Description for the changelog
FengPan-Frank
pushed a commit
to FengPan-Frank/sonic-buildimage
that referenced
this pull request
Mar 6, 2026
…tically (sonic-net#24791) #### Why I did it src/sonic-sairedis ``` * 1bf99980 - (HEAD -> master, origin/master, origin/HEAD) changes for vpp release 202510 (sonic-net#1695) (3 days ago) [aronovic] * 0ecbb5b9 - Revert "[meta] do not fail bulk operations if MODE_IGNORE_ERROR (sonic-net#1613)" (sonic-net#1676) (3 days ago) [Nikola Dancejic] * 3ab2f07d - Graceful shutdown vpp to avoid core dump (sonic-net#1714) (4 days ago) [yue-fred-gao] * a5e0e632 - Revert "Temp workaround for sonic-buildimage issue 23387 (sonic-net#1629)" (sonic-net#1700) (4 days ago) [Ze Gan] * b735b473 - Use sonic build pool for building sairedis (sonic-net#1719) (5 days ago) [Saikrishna Arcot] ``` #### How I did it #### How to verify it #### Description for the changelog Signed-off-by: Feng Pan <fenpan@microsoft.com>
dprital
pushed a commit
that referenced
this pull request
Mar 19, 2026
…tically (#24791) #### Why I did it src/sonic-sairedis ``` * 1bf99980 - (HEAD -> master, origin/master, origin/HEAD) changes for vpp release 202510 (#1695) (3 days ago) [aronovic] * 0ecbb5b9 - Revert "[meta] do not fail bulk operations if MODE_IGNORE_ERROR (#1613)" (#1676) (3 days ago) [Nikola Dancejic] * 3ab2f07d - Graceful shutdown vpp to avoid core dump (#1714) (4 days ago) [yue-fred-gao] * a5e0e632 - Revert "Temp workaround for sonic-buildimage issue 23387 (#1629)" (#1700) (4 days ago) [Ze Gan] * b735b473 - Use sonic build pool for building sairedis (#1719) (5 days ago) [Saikrishna Arcot] ``` #### How I did it #### How to verify it #### Description for the changelog Signed-off-by: dprital <drorp@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving get_routing_stack() to a centralized location to avoid code duplication.
Various areas of sonic-utilities are now demanding this functionality so i'm simply moving this routing to a centralized location. After spending some time debating about the ideal location for this function, we thought about sonic-config-engine/sonic_platform.py as the closest match.
Functional tests' output will be provided as part of the equivalent PR to be submitted shortly within sonic-utilities repo.