[docker-restapi] limit privileged flag for restapi container#17138
Merged
xumia merged 1 commit intosonic-net:masterfrom Nov 21, 2023
Merged
[docker-restapi] limit privileged flag for restapi container#17138xumia merged 1 commit intosonic-net:masterfrom
xumia merged 1 commit intosonic-net:masterfrom
Conversation
Signed-off-by: Mai Bui <maibui@microsoft.com>
Contributor
Author
|
@prsunny Could you help review this PR? |
Contributor
Author
|
@prsunny @theasianpianist Could you help review this PR? |
theasianpianist
approved these changes
Nov 20, 2023
Contributor
|
@xumia , does this break older branches? |
Collaborator
Contributor
Author
We don’t need to merge to older branches so it should not break older branches. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
HLD implementation: Container Hardening (sonic-net/SONiC#1364)
Work item tracking
How I did it
Reduce linux capabilities in privileged flag
How to verify it
Run restapi sonic-mgmt tests on sn4600c
Check container's settings: Privileged is false and container only has default Linux caps, does not have extended caps.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)