[minigraph parser] Fix minigraph parser issue when handling LAG related ACL table configuration#1712
Merged
qiluo-msft merged 4 commits intosonic-net:masterfrom May 26, 2018
keboliu:minigraph-parser
Merged
[minigraph parser] Fix minigraph parser issue when handling LAG related ACL table configuration#1712qiluo-msft merged 4 commits intosonic-net:masterfrom keboliu:minigraph-parser
qiluo-msft merged 4 commits intosonic-net:masterfrom
keboliu:minigraph-parser
Conversation
…guration Changes to be committed: modified: src/sonic-config-engine/minigraph.py modified: src/sonic-config-engine/tests/test_cfggen.py signed-off-by [email protected]
Collaborator
Author
|
PR updated to pick up the change in #sonic-net/sonic-swss#494 |
qiluo-msft
approved these changes
May 26, 2018
qiluo-msft
pushed a commit
to qiluo-msft/sonic-buildimage
that referenced
this pull request
May 27, 2018
…ed ACL table configuration (sonic-net#1712) * Fix minigraph parser issue when handling LAG related ACL table configuration * rephrase the warning message. * pick up swss change in sonic-net/sonic-swss#494
lguohan
pushed a commit
that referenced
this pull request
May 30, 2018
…ed ACL table configuration (#1712) * Fix minigraph parser issue when handling LAG related ACL table configuration * rephrase the warning message. * pick up swss change in sonic-net/sonic-swss#494
qiluo-msft
added a commit
to qiluo-msft/sonic-buildimage
that referenced
this pull request
Jun 4, 2018
…AG related ACL table configuration (sonic-net#1712)" This reverts commit d7ed638.
stephenxs
added a commit
to stephenxs/sonic-buildimage
that referenced
this pull request
Jun 29, 2021
bb383be2 [Dynamic Buffer Calc][Mellanox] Bug fixes and enhancements for the lua plugins for buffer pool calculation and headroom checking (sonic-net#1781) f949dfe9 [Dynamic Buffer Calc] Avoid creating lossy PG for admin down ports during initialization (sonic-net#1776) def0a914 Fix config prompt question issue (sonic-net#1799) 21f97506 [ci]: Merge azure pipelines from master to 202012 branch (sonic-net#1764) a83a2a42 [vstest]: add dvs_route fixture 849bdf9c [Mux] Add support for mux metrics to State DB (sonic-net#1757) 386de717 [qosorch] Dot1p map list initialization fix (sonic-net#1746) f99abdca [sub intf] Port object reference count update (sonic-net#1712) 4a00042d [vstest/nhg]: use dvs_route fixture to make test_nhg more robust Signed-off-by: Stephen Sun <[email protected]>
arlakshm
added a commit
that referenced
this pull request
Jul 21, 2021
This update includes the following commits acb5d84 Neetha John 2021-07-20 [configlet] Python3 compatible syntax for extracting a key from the dict (#1721) 9b7c58b arlakshm 2021-07-20 Load the database global_db only once for show cli (#1712) Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <[email protected]>
judyjoseph
added a commit
that referenced
this pull request
Aug 7, 2021
8b149a3 Load the database global_db only once for show cli (#1712) cd0e560 [config][interface][speed] Fixed the config interface speed in multiasic issue (#1739) b595ba6 [fast-reboot] revert the change of disabling counter polling before fast-reboot (#1744) 8518820 [minigraph] Donot enable PFC watchdog for MgmtTsToR (#1734) 2213774 [CLI][show][bgp] Fix the show ip bgp network command (#1733) 3526507 [configlet] Python3 compatible syntax for extracting a key from the dict (#1721) 5b56b97 [sonic_installer] don't print errors when installing an image not supporting app ext (#1719) a581955 [LLDP] Fix lldpshow script to enable display multiple MAC addresses on the same remote physical interface (#1657)
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
This update includes the following commits acb5d84 Neetha John 2021-07-20 [configlet] Python3 compatible syntax for extracting a key from the dict (sonic-net#1721) 9b7c58b arlakshm 2021-07-20 Load the database global_db only once for show cli (sonic-net#1712) Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <[email protected]>
theasianpianist
pushed a commit
to theasianpianist/sonic-buildimage
that referenced
this pull request
Feb 5, 2022
Signed-off-by: Wenda Ni <[email protected]> There are two parts of changes in this pr: The motivation is that for each Port object instantiated, it should be initialized in PortsOrch::m_port_ref_count. For each Port object to be removed, its m_port_ref_count check should be zero to proceed further. These operations are generic and therefore should also apply to sub port Port object. Currently, Port object reference count increments - When a router interface is created on top. - When an ACL table is bound to Port (i.e., becoming a member of the ACL table group associated with the Port object). Port object reference count decrements - When a router interface on top is removed. - When an ACL table is unbound from Port (i.e, removing membership from the ACL table group associated with the Port object). Item 1, router interface creation and removal, is of direct relevance to sub port Port object. The other part of change is the reference count update to parent port Port object when a sub port Port object is added/removed on top. This part is motivated by change in Add reference counting to ports for ACL bindings. What I did At sub port Port object instantiation - Init sub port Port object reference count - Increase parent port Port object reference count At sub port Port object removal - Check sub port Port object reference count drops to zero - Decrease parent port Port object reference count At physical port removal - Check physical port Port object reference count drops to zero How I verified it vs test extension Issue parent port removal at APPL_DB level before removing sub port interface. Verify that parent port persists in ASIC_DB until sub interface is removed. Without the change, extended vs test fails:
taras-keryk
pushed a commit
to taras-keryk/sonic-buildimage
that referenced
this pull request
Apr 28, 2022
Introduce a new function `load_db_config()`. This function will load the global database file or database config file based on the platform.
vmittal-msft
pushed a commit
to vmittal-msft/sonic-buildimage
that referenced
this pull request
Oct 20, 2025
…ta-7060x6 (sonic-net#1712) <!-- Please make sure you've read and understood our contributing guidelines: https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md failure_prs.log skip_prs.log Make sure all your commits include a signature generated with `git commit -s` ** If this is a bug fix, make sure your description includes "fixes #xxxx", or "closes #xxxx" or "resolves #xxxx" Please provide the following information: --> #### Why I did it The Vendor PN regex for Pinewave LPO pluggable optic was incorrect and hence, the NPU SI settings were not getting applied. Also, made the speed regex for 800G Eoptolink module more generic to apply SI settings for Eoptolink 800G LPO module ##### Work item tracking - Microsoft ADO **(number only)**: 35393055 #### How I did it Corrected Vendor PN regex for Pinewave LPO pluggable optic and modified speed regex for 800G Eoptolink module #### How to verify it <!-- If PR needs to be backported, then the PR must be tested against the base branch and the earliest backport release branch and provide tested image version on these two branches. For example, if the PR is requested for master, 202211 and 202012, then the requester needs to provide test results on master and 202012. --> #### Which release branch to backport (provide reason below if selected) <!-- - Note we only backport fixes to a release branch, *not* features! - Please also provide a reason for the backporting below. - e.g. - [x] 202006 --> - [ ] 202205 - [ ] 202211 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [x] 202503 #### Tested branch (Please provide the tested image version) <!-- - Please provide tested image version - e.g. - [x] 20201231.100 --> - [ ] <!-- image version 1 --> - [ ] <!-- image version 2 --> #### Description for the changelog <!-- Write a short (one line) summary that describes the changes in this pull request for inclusion in the changelog: --> <!-- Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU. --> #### Link to config_db schema for YANG module changes <!-- Provide a link to config_db schema for the table for which YANG model is defined Link should point to correct section on https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md --> #### A picture of a cute animal (not mandatory but encouraged)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a replication of PR #1609 , which was reverted and need to be merged after PR [AclOrch] aclOrch enhancement to handle LAG port not configured case . The modifcation in this PR already been reviewed and approved.
- What I did
Fix minigraph parser issue when handling LAG related case for ACL table:
- How I did it
- How to verify it
sonic-cfggen test during build.
run ACL and Everflow test on different topo.
- Description for the changelog
Changes to be committed:
modified: src/sonic-config-engine/minigraph.py
modified: src/sonic-config-engine/tests/test_cfggen.py
signed-off-by [email protected]
- A picture of a cute animal (not mandatory but encouraged)