[device/accton]:Update Accton-AS7326-56X by pollyhsu2git · Pull Request #1711 · sonic-net/sonic-buildimage

pollyhsu2git · 2018-05-15T08:45:49Z

Update Accton-AS7326-56X to adapt xxx.config.bcm based on the latest update of Device-Specific File Directory Structure
Update Accton-AS7326-56X upon the port link / led test upon bringing-up the new SAI version, 3.2.1.1 / OpenNSL, 3.5.0.4
Update Accton-AS7326-56X to add the MAC RESET opeation before bring-up the SDK based on the HW spec

- What I did
Update Accton-AS7326-56X based on the port link / led test via self bringing-up the new SAI version, 3.2.1.1 / OpenNSL, 3.5.0.4

- How I did it

Update Accton-AS7326-56X to adapt xxx.config.bcm based on the latest update of Device-Specific File Directory Structure the SONiC Porting Guide.
Update Accton-AS7326-56X against the latest update of the SONiC Porting Guide (https://github.com/Azure/SONiC/wiki/Porting-Guide).

- How to verify it

Target-verified the port mapping of 48x25G+8x100G as expected
Target-verified the port link of -48x25G+8x100G as expected
Target-verified the port led of -48x25G+8x100G as expected
Ran config_checker passed on our config.bcm

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

* Update Accton-AS7326-56X to adapt xxx.config.bcm based on the latest update of `Device-Specific File Directory Structure` * Update Accton-AS7326-56X upon the port link / led test upon bringing-up the new SAI version, 3.2.1.1 / OpenNSL, 3.5.0.4 * Update Accton-AS7326-56X to add the MAC RESET opeation before bring-up the SDK based on the HW spec Signed-off-by: polly_hsu@edge-core.com

* Update Accton-AS7326-56X to fix the issue of not linkup with other switch Signed-off-by: polly_hsu@edge-core.com

* Update Accton-AS7326-56X to fix the MAC RESET * Update Accton-AS7326-56X to modify the thermal_policy code Signed-off-by: polly_hsu@edge-core.com

lguohan · 2018-09-01T20:58:41Z

@pollyhsu2git , can you resolve conflict?

pollyhsu2git · 2018-09-03T02:37:16Z

@lguohan
We've updated our latest submodule code for resolving the conflict here~

pollyhsu2git · 2018-09-26T05:28:34Z

@lguohan @stcheng
May we know whether we still have the conflicting files shown (minigraph.xml / sonic-platform-modules-accton?

lguohan · 2018-09-26T08:12:03Z

yes, we have

Conflicting files
device/accton/x86_64-accton_as7326_56x-r0/minigraph.xml
platform/broadcom/sonic-platform-modules-accton

lguohan · 2018-09-26T08:15:27Z

btw, you no longer need to check-in minigraph.xml due to this commit.

#2050

pollyhsu2git · 2018-09-26T08:41:25Z

@lguohan
Thanks for the info~
For the sonic-platform-modules-accton conflict, do we do the compiling against the latest master base (Kernel 4)? or?

lguohan · 2018-09-26T08:44:37Z

all source code is in buildimage now.

pollyhsu2git · 2018-09-26T09:17:13Z

@lguohan
Thanks!
We'll watch your posted build status here~

nikos-github

@pollyhsu2git Can you please update your PR to latest by resolving any conflicts and also do NOT use submodules? We don't use submodules for the drivers in sonic anymore and everything has been brought into sonic-buildimage.

pollyhsu2git · 2018-11-15T04:47:13Z

@nikos-github
Got it! Sir~ We'll close this PR then. After we've tested it again with the latest Kernel 4, we'll create a new one.

Update the sonic-swss submodule. The following is the new commit in the submodule. ``` b34f783 Resolve neighbor when nexthop does not exist (#1704) 500e2e9 [voq/inbandif] Voq inbandif port (#1602) 9f22ba7 Handle IPv6 and ECMP routes to be programmed to ASIC (#1711) 1b916c3 [acl] Add regression test for `config acl` CLI command (#1694) 8bc7aee Allowing the first time FEC and AN configuration to be pushed to SAI (#1705) d0dd6ee [Dynamic buffer calc][Mellanox] Fix bug: buffer over subscription in buffer pool size calculation (#1706) d8b8ca9 fix for CRM available bug (#1699) 97f70d1 NAT : Update the CRM used counters for SNAT and DNAT entries (#1655) a4e05a7 [vstest] System lag test timing issue fix (#1692) ca8ba6d [vlan] Add support of VLAN host interface (#1645)

adf5ab58 [vstest/subintf] Add vs test case to validate processing sequence of APPL DB keys (sonic-net#1663) 8a732726 [intfsorch] Create subport with the entry contains necessary attributes (sonic-net#1650) 7ba813b2 [vstest/subintf] Update vs tests to validate physical port host interface vlan tag attribute (sonic-net#1634) ed32e333 [portsorch] Configure hostif tagging for subports (sonic-net#1573) b5209c43 Handle IPv6 and ECMP routes to be programmed to ASIC (sonic-net#1711) 515cc1a7 [Dynamic buffer calc][Mellanox] Fix bug: buffer over subscription in buffer pool size calculation (sonic-net#1706) 0ad524b2 [202012] Allowing the first time FEC and AN configuration to be pushed to SAI (sonic-net#1710) Signed-off-by: Stephen Sun <stephens@nvidia.com>

adf5ab58 [vstest/subintf] Add vs test case to validate processing sequence of APPL DB keys (#1663) 8a732726 [intfsorch] Create subport with the entry contains necessary attributes (#1650) 7ba813b2 [vstest/subintf] Update vs tests to validate physical port host interface vlan tag attribute (#1634) ed32e333 [portsorch] Configure hostif tagging for subports (#1573) b5209c43 Handle IPv6 and ECMP routes to be programmed to ASIC (#1711) 515cc1a7 [Dynamic buffer calc][Mellanox] Fix bug: buffer over subscription in buffer pool size calculation (#1706) 0ad524b2 [202012] Allowing the first time FEC and AN configuration to be pushed to SAI (#1710) Signed-off-by: Stephen Sun <stephens@nvidia.com>

Update the sonic-swss submodule. The following is the new commit in the submodule. ``` b34f783 Resolve neighbor when nexthop does not exist (sonic-net#1704) 500e2e9 [voq/inbandif] Voq inbandif port (sonic-net#1602) 9f22ba7 Handle IPv6 and ECMP routes to be programmed to ASIC (sonic-net#1711) 1b916c3 [acl] Add regression test for `config acl` CLI command (sonic-net#1694) 8bc7aee Allowing the first time FEC and AN configuration to be pushed to SAI (sonic-net#1705) d0dd6ee [Dynamic buffer calc][Mellanox] Fix bug: buffer over subscription in buffer pool size calculation (sonic-net#1706) d8b8ca9 fix for CRM available bug (sonic-net#1699) 97f70d1 NAT : Update the CRM used counters for SNAT and DNAT entries (sonic-net#1655) a4e05a7 [vstest] System lag test timing issue fix (sonic-net#1692) ca8ba6d [vlan] Add support of VLAN host interface (sonic-net#1645)

List of commits (newest first): sonic-net/sonic-utilities@0efd297 (origin/master, origin/HEAD) mclag enhancements as per HLD at sonic-net/SONiC#596 (#1138) sonic-net/sonic-utilities@e98bbb6 Reworked IP validation in "config interface ip add/remove" command (#1709) sonic-net/sonic-utilities@866d1d7 [minigraph][port_config] Consume port_config.json while reloading minigraph (#1705) sonic-net/sonic-utilities@9ae6f6b [debug dump util] Match Infrastructure (#1666) sonic-net/sonic-utilities@8fe7e26 Coverage uses top level directory as source (#1711) sonic-net/sonic-utilities@3f0b690 [MPLS][CLI] added config/show CLI for MPLS interface, MPLS CRM threshold config, updated CLI reference manual sonic-net/sonic-utilities@e8b6c5c [ci] Fix python coverage color bar (#1692) sonic-net/sonic-utilities@888701b [Mellanox] Remove mstdump from Mellanoxs collect dump script (#1706) sonic-net/sonic-utilities@4818360 [sonic-package-manager] support warm/fast reboot for extension packages (#1554) sonic-net/sonic-utilities@793b847 [show priority-group drop counters] Remove backup with cached PG drop counters after 'config reload' (#1679) sonic-net/sonic-utilities@24fe1ac [show][config] support for interface alias for muxcable commands (#1699) sonic-net/sonic-utilities@186d851 Pcieutil to load the platform api first instead of using common api (#1672) sonic-net/sonic-utilities@7a82c06 [Mellanox] Update mellanox dump generation to include SDK dumps (#1640) sonic-net/sonic-utilities@38f8c06 [sfputil] Expose error status fetched from STATE_DB or platform API to CLI (#1658) sonic-net/sonic-utilities@c5d00ae [pfcwd] Fix the return code in invalid case (#1691) sonic-net/sonic-utilities@57dc403 [ci]: Fix config prompt question issue (#1693) sonic-net/sonic-utilities@5708497 [show] fix show version (#1686) sonic-net/sonic-utilities@9041ba0 [config] Adding sanity checks for config reload (#1664) sonic-net/sonic-utilities@2cdadb5 [config]: Create portchannel with LACP key (#1473) sonic-net/sonic-utilities@6f74ba5 [vnet_route_check] Fix logic for getting VNET routes from ASIC DB (#1653) sonic-net/sonic-utilities@54fee0f Add range check on portchannel min-links (#1630)

Update the sonic-swss submodule. The following is the new commit in the submodule. ``` b34f783 Resolve neighbor when nexthop does not exist (sonic-net#1704) 500e2e9 [voq/inbandif] Voq inbandif port (sonic-net#1602) 9f22ba7 Handle IPv6 and ECMP routes to be programmed to ASIC (sonic-net#1711) 1b916c3 [acl] Add regression test for `config acl` CLI command (sonic-net#1694) 8bc7aee Allowing the first time FEC and AN configuration to be pushed to SAI (sonic-net#1705) d0dd6ee [Dynamic buffer calc][Mellanox] Fix bug: buffer over subscription in buffer pool size calculation (sonic-net#1706) d8b8ca9 fix for CRM available bug (sonic-net#1699) 97f70d1 NAT : Update the CRM used counters for SNAT and DNAT entries (sonic-net#1655) a4e05a7 [vstest] System lag test timing issue fix (sonic-net#1692) ca8ba6d [vlan] Add support of VLAN host interface (sonic-net#1645)

List of commits (newest first): sonic-net/sonic-utilities@0efd297 (origin/master, origin/HEAD) mclag enhancements as per HLD at sonic-net/SONiC#596 (sonic-net#1138) sonic-net/sonic-utilities@e98bbb6 Reworked IP validation in "config interface ip add/remove" command (sonic-net#1709) sonic-net/sonic-utilities@866d1d7 [minigraph][port_config] Consume port_config.json while reloading minigraph (sonic-net#1705) sonic-net/sonic-utilities@9ae6f6b [debug dump util] Match Infrastructure (sonic-net#1666) sonic-net/sonic-utilities@8fe7e26 Coverage uses top level directory as source (sonic-net#1711) sonic-net/sonic-utilities@3f0b690 [MPLS][CLI] added config/show CLI for MPLS interface, MPLS CRM threshold config, updated CLI reference manual sonic-net/sonic-utilities@e8b6c5c [ci] Fix python coverage color bar (sonic-net#1692) sonic-net/sonic-utilities@888701b [Mellanox] Remove mstdump from Mellanoxs collect dump script (sonic-net#1706) sonic-net/sonic-utilities@4818360 [sonic-package-manager] support warm/fast reboot for extension packages (sonic-net#1554) sonic-net/sonic-utilities@793b847 [show priority-group drop counters] Remove backup with cached PG drop counters after 'config reload' (sonic-net#1679) sonic-net/sonic-utilities@24fe1ac [show][config] support for interface alias for muxcable commands (sonic-net#1699) sonic-net/sonic-utilities@186d851 Pcieutil to load the platform api first instead of using common api (sonic-net#1672) sonic-net/sonic-utilities@7a82c06 [Mellanox] Update mellanox dump generation to include SDK dumps (sonic-net#1640) sonic-net/sonic-utilities@38f8c06 [sfputil] Expose error status fetched from STATE_DB or platform API to CLI (sonic-net#1658) sonic-net/sonic-utilities@c5d00ae [pfcwd] Fix the return code in invalid case (sonic-net#1691) sonic-net/sonic-utilities@57dc403 [ci]: Fix config prompt question issue (sonic-net#1693) sonic-net/sonic-utilities@5708497 [show] fix show version (sonic-net#1686) sonic-net/sonic-utilities@9041ba0 [config] Adding sanity checks for config reload (sonic-net#1664) sonic-net/sonic-utilities@2cdadb5 [config]: Create portchannel with LACP key (sonic-net#1473) sonic-net/sonic-utilities@6f74ba5 [vnet_route_check] Fix logic for getting VNET routes from ASIC DB (sonic-net#1653) sonic-net/sonic-utilities@54fee0f Add range check on portchannel min-links (sonic-net#1630)

*In case of standby mux, associated routes may come to orch with ifname of tun0. Handle the case when nexthop is non-zero *For ECMP, multiple nexthop IPs can have the same sai nexthop id (tunnel NH). Existing data structure is unable to handle such case. Added a secondary map if nexthops are shared

Originally, the Azure pipeline "Code Coverage" page will render folder structure wrongly. The first level of folders disappear and all the files in the first level are combined and de-dup. So we lost many main.py, etc. Fix the coveragerc file so that the rendering will make sense.

…ance dependencies (sonic-net#1711) #### Why I did it ***Important***: Please review each commit (including commit message) individually. Looking at the patch-set as a whole may cause confusion. Generic Config Updater (GCU) is notoriously slow. These patches add some helpers for the GCU overhaul (mostly in sonic-utilities) in order to facilitate the optimizations. These changes are in sonic-yang-mgmt plus a patch to libyang 1. Changes include: failure_prs.log skip_prs.log Libyang v1 was not exposing `must` data for leaf nodes (like it does for other node types). Patch to correct this oversight. failure_prs.log skip_prs.log Loading of sonic configuration data should not mutate the user-provided data, this forces callers to know they need to deepcopy the data, plus in most instances data won't be mutated. failure_prs.log skip_prs.log sonic-yang-mgmt test models should more closely mimic real sonic yang models as we can't implement other features that assume this otherwise (sonic mandates that the top-level container has the same name as the module). failure_prs.log skip_prs.log Import `sonic configdb`<>`yang xpath` conversion from sonic-utilities as this should be shared code. 90% of this code is copied from the original source but does contain some bugfixes and enhancements including caching. failure_prs.log skip_prs.log Make `find_schema_dependencies()` public, plus add the ability to find dependencies recursively. This implementation is caching. failure_prs.log skip_prs.log Add new `find_schema_must_count()`, with recursive capabilities to find if a node (and its children) have must clauses. This implementation is caching. sonic-utilities PR: sonic-net/sonic-utilities#3831 Stats below ... (stats need both this and the sonic-utilities PR to be relevant)... <ins>**Original Performance:**</ins> Dry Run: ``` time sudo config replace -d ./config_db.json ... real 2m51.588s user 2m23.777s sys 0m25.300s ``` Full: ``` time sudo config replace ./config_db.json ... real 14m53.772s user 12m2.376s sys 2m8.908s ``` <ins>**With Patch**:</ins> Dry Run: ``` time sudo config replace -d ./config_db.json ... real 0m59.602s user 0m56.434s sys 0m2.110s ``` Full: ``` time sudo config replace ./config_db.json ... real 1m54.303s user 0m58.482s sys 0m2.545s ``` So that's roughly 3x improvement for dry-run, and 7.5x improvement for full commit. There is room for improvement on the full commit due to a `sleep(1)` being used between each patch because of a race condition found in the prior code (that was hidden due to a costly sanity check that has been removed). ##### Work item tracking #### How I did it Gathered profiling data using cProfile and evaluated where the largest gains could be had. #### How to verify it This patch is standalone as it will not cause any issues in other projects which use sonic-yang-mgmt or libyang, however the performance benefits are in sonic-utilities. Apply both this commit and the sonic-utilities PR to a local branch, build and run sonic-utilities tests. Then create a full image, load it onto a DUT (with default configuration), and use the attached [config_db.json](https://github.com/user-attachments/files/19635712/config_db.json) to attempt a `config replace` operation (tested on Dell S5248F). #### Which release branch to backport (provide reason below if selected) - [x] 202411 #### Tested branch (Please provide the tested image version) master as of 20250521 #### Description for the changelog sonic-yang-mgmt: Generic Config Updater - performance dependencies #### Link to config_db schema for YANG module changes N/A #### A picture of a cute animal (not mandatory but encouraged) Fixes sonic-net#22372 Signed-off-by: Brad House <bhouse@nexthop.ai>

Polly Hsu added 4 commits May 15, 2018 16:41

Update Accton-AS7326-56X

b91b14e

* Update Accton-AS7326-56X to fix the issue of not linkup with other switch Signed-off-by: polly_hsu@edge-core.com

[device/accton]: Update the build fix due to un-resolved conflicts

9d42150

Update Accton-AS7326-56X

927ee63

* Update Accton-AS7326-56X to fix the MAC RESET * Update Accton-AS7326-56X to modify the thermal_policy code Signed-off-by: polly_hsu@edge-core.com

[device/accton]: Update the latest due to un-resolved conflicts

6228025

stcheng added Enhancement ➕ Submodule Update ⏫ Platform: Accton labels Sep 11, 2018

nikos-github reviewed Nov 14, 2018

View reviewed changes

pollyhsu2git closed this Nov 15, 2018

pollyhsu2git deleted the update-as7326_56x branch January 25, 2019 02:28

haslersn mentioned this pull request Jul 17, 2021

updating sonic-utilities submodule #8203

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[device/accton]:Update Accton-AS7326-56X#1711

[device/accton]:Update Accton-AS7326-56X#1711
pollyhsu2git wants to merge 5 commits intosonic-net:masterfrom
pollyhsu2git:update-as7326_56x

pollyhsu2git commented May 15, 2018 •

edited

Loading

Uh oh!

lguohan commented Sep 1, 2018

Uh oh!

pollyhsu2git commented Sep 3, 2018

Uh oh!

pollyhsu2git commented Sep 26, 2018

Uh oh!

lguohan commented Sep 26, 2018

Uh oh!

lguohan commented Sep 26, 2018

Uh oh!

pollyhsu2git commented Sep 26, 2018

Uh oh!

lguohan commented Sep 26, 2018

Uh oh!

pollyhsu2git commented Sep 26, 2018

Uh oh!

nikos-github left a comment

Uh oh!

pollyhsu2git commented Nov 15, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

pollyhsu2git commented May 15, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lguohan commented Sep 1, 2018

Uh oh!

pollyhsu2git commented Sep 3, 2018

Uh oh!

pollyhsu2git commented Sep 26, 2018

Uh oh!

lguohan commented Sep 26, 2018

Uh oh!

lguohan commented Sep 26, 2018

Uh oh!

pollyhsu2git commented Sep 26, 2018

Uh oh!

lguohan commented Sep 26, 2018

Uh oh!

pollyhsu2git commented Sep 26, 2018

Uh oh!

nikos-github left a comment

Choose a reason for hiding this comment

Uh oh!

pollyhsu2git commented Nov 15, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pollyhsu2git commented May 15, 2018 •

edited

Loading