[device/dell] Add z9100 pfc T0 support#1708
Merged
yxieca merged 1 commit intosonic-net:masterfrom May 21, 2018
Merged
Conversation
Contributor
Author
|
@yxieca Can you please review |
prsunny
reviewed
May 15, 2018
Contributor
There was a problem hiding this comment.
Have you followed the porting guide, particularly testing on your target device and making sure that all ports come up online.
prsunny
reviewed
May 15, 2018
Contributor
There was a problem hiding this comment.
Just a suggestion to use one convention, either all alias name starts with lowercase or all with uppercase. Also, in my understanding, if name says fiftyGig it must follow same naming as hundredGig.. like fiftyGigE1/1, 1/2, 1/3..
Contributor
Author
There was a problem hiding this comment.
I followed the convention like what was done in FTOS where it is fiftyGiGE1/1/1 and 1/1/2.
Contributor
There was a problem hiding this comment.
The point is at the first letter, please use lower case as you suggested.
Contributor
There was a problem hiding this comment.
Just an observation, rest of the config files specify G as in 8x100G
Contributor
Author
There was a problem hiding this comment.
ok will change accordingly
yxieca
requested changes
May 15, 2018
Contributor
yxieca
left a comment
yxieca
left a comment
There was a problem hiding this comment.
- Please add your bcm.config file to this folder.
- Change sail.profile according to the porting guide.
- Test on the target dut and make sure that all ports come up online.
This commit adds new code to support z9100 PFC T0 support with broadcom recommended MMU settings for PFC feature. Unit tested the setting by loading sonic-broadcom.bin and checking the hardware for the values from the JSON file. The T0 configs supports fan-out of 100G ports on Z9100. Added new config.bcm for fanout of 100G ports and tested the fanout by sending traffic using bcmcmd, new config.bcm file will be copied to /usr/share/sonic/hwsku/th-z9100-8x100-48x50G.config.bcm. The sai.profile file is updated to point to hwsku directory. Signed-off-by: Harish Venkatraman <[email protected]>
vharish02
force-pushed
the
z9100-pfc-t0-support
branch
from
1dbbd09 to
741a1b3
Compare
yxieca
approved these changes
May 21, 2018
daall
added a commit
to daall/sonic-buildimage
that referenced
this pull request
Apr 29, 2021
sonic-swss: - [Monitor Vlan] Fix a typo in hostif (sonic-net#1722) - Update pool sizes during initialization from timer only (sonic-net#1708) - [SflowMgr] SamplingRate Update by Speed Change Added (sonic-net#1721) sonic-swss-common: - [swss-common] Add MUX Metrics Table (sonic-net#482) - [azp] Purge swss before installing the newly built deb package (sonic-net#472) sonic-utilities: - disk_check: Check & mount RO as RW using tmpfs (sonic-net#1569) - No more IP validation as it is more likely a URL (sonic-net#1555) - Stop PMON docker before cold and soft reboots (sonic-net#1514) - Add soft-reboot reboot type (sonic-net#1453) - [acl] Use a list instead of a comma-separated string for ACL port list (sonic-net#1519) - sonic-installer: fix py3 issues in bootloader.aboot (sonic-net#1553) - Fix unsupported fs.squashfs extraction in sonic-installer (sonic-net#1366) - [show][config] cli support for firmware upgrade on Y-Cable (sonic-net#1528) (sonic-net#1558) sonic-linux-kernel: - [Mellanox] backport kernel patches for hw-management 7.0100.2303 (sonic-net#211) Signed-off-by: Danny Allen <[email protected]>
4 tasks
lguohan
pushed a commit
that referenced
this pull request
May 4, 2021
* [202012][swss/swss-common/utilities/kernel] Update submodule sonic-swss: - [Monitor Vlan] Fix a typo in hostif (#1722) - Update pool sizes during initialization from timer only (#1708) - [SflowMgr] SamplingRate Update by Speed Change Added (#1721) sonic-swss-common: - [swss-common] Add MUX Metrics Table (#482) - [azp] Purge swss before installing the newly built deb package (#472) sonic-utilities: - disk_check: Check & mount RO as RW using tmpfs (#1569) - No more IP validation as it is more likely a URL (#1555) - Stop PMON docker before cold and soft reboots (#1514) - Add soft-reboot reboot type (#1453) - [acl] Use a list instead of a comma-separated string for ACL port list (#1519) - sonic-installer: fix py3 issues in bootloader.aboot (#1553) - Fix unsupported fs.squashfs extraction in sonic-installer (#1366) - [show][config] cli support for firmware upgrade on Y-Cable (#1528) (#1558) sonic-linux-kernel: - [Mellanox] backport kernel patches for hw-management 7.0100.2303 (#211) Signed-off-by: Danny Allen <[email protected]> * Update utilities w/ build fix
vdahiya12
added a commit
to vdahiya12/sonic-buildimage
that referenced
this pull request
Jul 28, 2021
this PR updates the following commits c2ac2d2 [show] fix show muxcable metrics <port> for sorted output (sonic-net#1731) 4422911 [fwutil]: Update command reference doc: per component FW update. (sonic-net#1708) b83d2bf [minigraph][port_config] Use imported config.main and add conditional patch (sonic-net#1724) Signed-off-by: vaibhav-dahiya <[email protected]>
5 tasks
lguohan
pushed a commit
that referenced
this pull request
Jul 31, 2021
this PR updates the following commits c2ac2d2 [show] fix show muxcable metrics <port> for sorted output (#1731) 4422911 [fwutil]: Update command reference doc: per component FW update. (#1708) b83d2bf [minigraph][port_config] Use imported config.main and add conditional patch (#1724) Signed-off-by: vaibhav-dahiya <[email protected]>
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
this PR updates the following commits c2ac2d2 [show] fix show muxcable metrics <port> for sorted output (sonic-net#1731) 4422911 [fwutil]: Update command reference doc: per component FW update. (sonic-net#1708) b83d2bf [minigraph][port_config] Use imported config.main and add conditional patch (sonic-net#1724) Signed-off-by: vaibhav-dahiya <[email protected]>
theasianpianist
pushed a commit
to theasianpianist/sonic-buildimage
that referenced
this pull request
Feb 5, 2022
- What I did This is a supplement of sonic-net#1685. In that PR, most of the cases in which the buffer pool updated during initialization have been avoided but there are still some rare cases not covered. Eg., it will try to recalculate the pool size because the lossless PSs are removed if one port is admin down. - Why I did it Make sure that the the buffer pools will be updated only once during initialization. - How I verified it Run regression and manual test Signed-off-by: Stephen Sun <[email protected]>
taras-keryk
pushed a commit
to taras-keryk/sonic-buildimage
that referenced
this pull request
Apr 28, 2022
…ic-net#1708) Signed-off-by: Nazarii Hnydyn <[email protected]> What I did Updated command reference to match fwutil v.2.0.0.0 How I did it Updated command reference
9 tasks
noaOrMlnx
pushed a commit
to noaOrMlnx/sonic-buildimage
that referenced
this pull request
Oct 26, 2025
…onic-net#1708) <!-- Please make sure you've read and understood our contributing guidelines: https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md ** Make sure all your commits include a signature generated with `git commit -s` ** If this is a bug fix, make sure your description includes "fixes #xxxx", or "closes #xxxx" or "resolves #xxxx" Please provide the following information: --> #### Why I did it Manual cherrypick for sonic-net#24053 due to conflict. Integrate SHOW API probe into telemetry watchdog. We want the watchdog to catch the bad SHOW command implementation. ##### Work item tracking - Microsoft ADO **(number only)**:34793098 #### How I did it Add gnmi_get into telemetry-watchdog, and call gnmi_get in the watchdog http service for each probe, as long as one xpath fails, the probe will return 500. The watchdog will read xpath list from /cmd_list.json and environment variables. #### How to verify it Run the telemetry-watchdog container, call curl http://127.0.0.1:50080/ to check if the output is expected or not. root@bjw-can-2700-2:/# curl -s http://127.0.0.1:50080/ |jq . { "check_telemetry_port": "OK", "xpath_commands": [ { "xpath": "clock", "success": true, "error": null, "duration_ms": 200 } ] } <!-- If PR needs to be backported, then the PR must be tested against the base branch and the earliest backport release branch and provide tested image version on these two branches. For example, if the PR is requested for master, 202211 and 202012, then the requester needs to provide test results on master and 202012. --> #### Which release branch to backport (provide reason below if selected) <!-- - Note we only backport fixes to a release branch, *not* features! - Please also provide a reason for the backporting below. - e.g. - [x] 202006 --> - [ ] 201811 - [ ] 201911 - [ ] 202006 - [ ] 202012 - [ ] 202106 - [ ] 202111 - [ ] 202205 - [ ] 202211 #### Tested branch (Please provide the tested image version) <!-- - Please provide tested image version - e.g. - [x] 20201231.100 --> - [ ] <!-- image version 1 --> - [ ] <!-- image version 2 --> #### Description for the changelog <!-- Write a short (one line) summary that describes the changes in this pull request for inclusion in the changelog: --> <!-- Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU. --> #### Link to config_db schema for YANG module changes <!-- Provide a link to config_db schema for the table for which YANG model is defined Link should point to correct section on https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md --> #### A picture of a cute animal (not mandatory but encouraged)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds new code to support z9100 PFC T0 support with
broadcom recommended MMU settings for PFC feature.
Unit tested the setting by loading sonic-broadcom.bin and checking
the hardware for the values from the JSON file. The T0 configs supports
fan-out of 100G ports on Z9100. Added new config.bcm for fanout of 100G
ports and tested the fanout by sending traffic using bcmcmd, new file
will be copied to /etc/bcm/th-z9100-8x100-48x50G.config.bcm. This file
has to be packaged with libsaibcm library. Will send the file to Ying.
Signed-off-by: Harish Venkatraman [email protected]
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)