[docker-sflow] limit privileged flag for sflow container#16973
Merged
qiluo-msft merged 1 commit intosonic-net:masterfrom Oct 27, 2023
Merged
[docker-sflow] limit privileged flag for sflow container#16973qiluo-msft merged 1 commit intosonic-net:masterfrom
qiluo-msft merged 1 commit intosonic-net:masterfrom
Conversation
Signed-off-by: Mai Bui <[email protected]>
Collaborator
|
@padmanarayana @mint570 Could you help review? |
Contributor
|
@maipbui Did you test the change with sflow community tests? or make sure if the pipelines run the sflow tests |
Collaborator
|
Asked @padmanarayana and @Gokulnath-Raja to help review. |
Contributor
Author
Contributor
|
Change looks good. |
vadymhlushko-mlnx
approved these changes
Oct 24, 2023
Contributor
I am fine with the changes |
qiluo-msft
approved these changes
Oct 27, 2023
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
HLD implementation: Container Hardening (sonic-net/SONiC#1364)
Work item tracking
How I did it
Reduce linux capabilities in privileged flag
How to verify it
Run sflow sonic-mgmt tests
Check container's settings: Privileged is false and container only has default Linux caps, does not have extended caps.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)