Add LDAP feature support#16969
Conversation
davidpil2002
force-pushed
the
dev-add-ldap-support
branch
from
3593baf to
c1cc33c
Compare
davidpil2002
force-pushed
the
dev-add-ldap-support
branch
3 times, most recently
from
e34d037 to
d3ac900
Compare
|
@lguohan who should review and provide feedback? |
|
@a-barboza Could you also help review this PR? |
|
yang-model tests are missing for LDAP, please add the same. |
davidpil2002
force-pushed
the
dev-add-ldap-support
branch
2 times, most recently
from
e4d1f05 to
553ac32
Compare
davidpil2002
force-pushed
the
dev-add-ldap-support
branch
4 times, most recently
from
4343811 to
4ea585d
Compare
|
error look not related to the new code. |
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
DONE |
|
All comments was answered, |
|
@a-barboza , could you please review? I saw you did HLD review as well |
davidpil2002
force-pushed
the
dev-add-ldap-support
branch
2 times, most recently
from
9485c3b to
31c62b6
Compare
davidpil2002
force-pushed
the
dev-add-ldap-support
branch
from
31c62b6 to
4f7f048
Compare
davidpil2002
force-pushed
the
dev-add-ldap-support
branch
from
08ca0bc to
65d17d7
Compare
| # package for supporting password hardening | ||
| sudo LANG=C DEBIAN_FRONTEND=noninteractive chroot $FILESYSTEM_ROOT apt-get -y install libpam-pwquality | ||
|
|
||
| # Install pam-ldap, nss-ldap, ldap-utils |
There was a problem hiding this comment.
Why should this be different than radius/tacacs? Why show different approaches for a feature in the same domain?
|
/azpw run Azure.sonic-buildimage |
liat-grozovik
left a comment
liat-grozovik
left a comment
There was a problem hiding this comment.
offline discussion confirms PR has no additional comments and thus can be merged.
if more comments will be provided after the merge it will be discussed and considered if change is required.
10 participants
Why I did it
To support LDAP feature
Work item tracking
How I did it
Similar to Radius/Tacacs authentication methods, the SONiC device is the LDAP client.
Installed the Debian LDAP packages related to making SONiC able to function as an LDAP client.
More description in the following HLD:
sonic-net/SONiC#1487
How to verify it
Do LDAP configuration according to the HLD, then connect to the SONiC switch by using a user that exists in your LDAP server.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
YANG Schema can be found attached in the HLD as well.
A picture of a cute animal (not mandatory but encouraged)