[Mellanox] CMIS management feature enablement #16968
Merged
liat-grozovik merged 7 commits intosonic-net:masterfrom Apr 14, 2024
Merged
[Mellanox] CMIS management feature enablement #16968liat-grozovik merged 7 commits intosonic-net:masterfrom
liat-grozovik merged 7 commits intosonic-net:masterfrom
Conversation
prgeor
previously approved these changes
Dec 1, 2023
Collaborator
|
@dbarashinvd please add also recent added SKU to this PR done by @DavidZagury. |
liat-grozovik
requested changes
Dec 14, 2023
Collaborator
liat-grozovik
left a comment
liat-grozovik
left a comment
There was a problem hiding this comment.
see comment below
Contributor
Author
working on it. cant get the new SKU folder for update after fetch and rebase. will sort it out and update |
Contributor
Author
done |
Contributor
|
@liat-grozovik @dbarashinvd please see if this can be moved out of draft and unblocked? |
put content directly in sai.profile
Contributor
|
@moshemos @liat-grozovik @keboliu What is pending for this to be enabled? |
zhangyanzhao
changed the title
Collaborator
|
New asic and platform driver update. Should be in few days on another pr
Get Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: Prince George ***@***.***>
Sent: Friday, April 5, 2024 12:41:24 AM
To: sonic-net/sonic-buildimage ***@***.***>
Cc: Liat Grozovik ***@***.***>; Mention ***@***.***>
Subject: Re: [sonic-net/sonic-buildimage] CMIS management feature enablement for MSFT HWSKU (PR #16968)
@moshemos<https://github.com/moshemos> @liat-grozovik<https://github.com/liat-grozovik> @keboliu<https://github.com/keboliu> What is pending for this to be enabled?
—
Reply to this email directly, view it on GitHub<#16968 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AKTABA63F7EL4YMYMMR7IFTY3XCIJAVCNFSM6AAAAAA6LYAWXOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZYGI4DCMJVGU>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
liat-grozovik
approved these changes
Apr 7, 2024
prgeor
approved these changes
Apr 8, 2024
Contributor
|
@liat-grozovik can you please merge? |
liat-grozovik
changed the title
Collaborator
|
@yxieca can you please cherry-pick to 202311? |
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
May 16, 2024
- Why I did it CMIS management feature enablement - How I did it Add new variable with value 1 for CMIS management feature enablement under specific HWSKU folder. Not the default one - How to verify it Install image on switch with same HWSKU and check "show interfaces status" (Type column)
Collaborator
|
Cherry-pick PR to 202311: #18982 |
mssonicbld
pushed a commit
that referenced
this pull request
May 17, 2024
- Why I did it CMIS management feature enablement - How I did it Add new variable with value 1 for CMIS management feature enablement under specific HWSKU folder. Not the default one - How to verify it Install image on switch with same HWSKU and check "show interfaces status" (Type column)
mssonicbld
added
Included in 202311 Branch
and removed
Created PR to 202311 Branch
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #18571
Why I did it
CMIS management feature enablement
Work item tracking
How I did it
Add new variable with value 1 for CMIS management feature enablement under specific HWSKU folder. Not the default one
How to verify it
Install image on switch with same HWSKU and check "show interfaces status" (Type column)
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)