Skip to content

[submodule] Update sonic-pins submodule#16825

Merged
yxieca merged 1 commit intosonic-net:masterfrom
saiarcot895:update-sonic-pins-submodule
Oct 25, 2023
Merged

[submodule] Update sonic-pins submodule#16825
yxieca merged 1 commit intosonic-net:masterfrom
saiarcot895:update-sonic-pins-submodule

Conversation

@saiarcot895
Copy link
Contributor

Why I did it

Update the sonic-pins submodule. This brings in the following commit:

56a7762 Use json.hpp from nlohmann-json-dev instead of from swss-common (#22)
Work item tracking
  • Microsoft ADO (number only):

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Saikrishna Arcot <[email protected]>
@saiarcot895 saiarcot895 requested a review from lguohan as a code owner October 10, 2023 16:08
@saiarcot895 saiarcot895 changed the title Update sonic-pins submodule [submodule] Update sonic-pins submodule Oct 10, 2023
@yxieca
Copy link
Contributor

yxieca commented Oct 25, 2023

@xumia @liushilongbuaa can you check why PINS submodule is not handled by automation?

@yxieca yxieca merged commit c738cb5 into sonic-net:master Oct 25, 2023
@liushilongbuaa
Copy link
Contributor

@yxieca , because sonic-pins used main branch instead of master.
Automation only works for same branch with sonic-buildimage.

@liushilongbuaa
Copy link
Contributor

https://github.com/sonic-net/sonic-genl-packet
This repo also used main instead of master.

@yxieca
Copy link
Contributor

yxieca commented Oct 25, 2023

https://github.com/sonic-net/sonic-genl-packet This repo also used main instead of master.

Is it possible to add support?

@liushilongbuaa
Copy link
Contributor

https://github.com/sonic-net/sonic-genl-packet This repo also used main instead of master.

Is it possible to add support?

sure. If it updates submodule for master branch, check master branch first then main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants