Skip to content

Add special rsyslog filter for MSN2700 platform - #16684

Merged
liat-grozovik merged 1 commit into
sonic-net:masterfrom
keboliu:master_msn2700_syslog_file
Oct 24, 2023
Merged

Add special rsyslog filter for MSN2700 platform#16684
liat-grozovik merged 1 commit into
sonic-net:masterfrom
keboliu:master_msn2700_syslog_file

Conversation

@keboliu

@keboliu keboliu commented Sep 25, 2023

Copy link
Copy Markdown
Collaborator

Why I did it

Mellanox MSN2700 platforms have a non-functional error log: "ERR pmon#sensord: Error getting sensor data: dps460/#10: Can't read". This error is because of a firmware issue with some PSU, we are not able to upgrade the FW online. Since there is no functional impact, this error log can be ignored safely.

Work item tracking
  • Microsoft ADO (number only):

How I did it

Add a new rsyslog rule to the rsyslog-container.conf.j2, if the docker name is pmon and the platform name matches, the new rule will be inserted into the docker rsyslogd.conf

How to verify it

run regression on the MSN2700 platform to make the error log will not be printed to the syslog.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@prgeor

prgeor commented Sep 25, 2023

Copy link
Copy Markdown
Contributor

@keboliu can we use sensord configuration file to ignore the sensor reading?

@keboliu
keboliu marked this pull request as ready for review September 27, 2023 05:46
@keboliu
keboliu requested a review from lguohan as a code owner September 27, 2023 05:46
@keboliu

keboliu commented Sep 27, 2023

Copy link
Copy Markdown
Collaborator Author

@keboliu can we use sensord configuration file to ignore the sensor reading?

Hi @prgeor , sensor conf is not able to address all the scenarios, it still can happen when sensord scan all the sensors in the background.

liat-grozovik
liat-grozovik previously approved these changes Oct 9, 2023

@prgeor prgeor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@keboliu to prevent overwhelming the host rsyslogd, please do the filtering inside the PMON. To make this working in PMON, we need to keep this action at the end of the rsyslog conf file:-https://github.com/sonic-net/sonic-buildimage/blob/master/files/image_config/rsyslog/rsyslog-container.conf.j2#L56

@keboliu

keboliu commented Oct 20, 2023

Copy link
Copy Markdown
Collaborator Author

@keboliu to prevent overwhelming the host rsyslogd, please do the filtering inside the PMON. To make this working in PMON, we need to keep this action at the end of the rsyslog conf file:-https://github.com/sonic-net/sonic-buildimage/blob/master/files/image_config/rsyslog/rsyslog-container.conf.j2#L56

I tried to add the rule to the rsyslog.conf inside pmon docker, but it doesn't work.

…_64-mlnx_msn2700a1-r0 platforms

Signed-off-by: Kebo Liu <kebol@nvidia.com>
@prgeor

prgeor commented Oct 23, 2023

Copy link
Copy Markdown
Contributor

@saiarcot895 could you review?

@prgeor

prgeor commented Oct 24, 2023

Copy link
Copy Markdown
Contributor

@liat-grozovik @lguohan please merge

@liat-grozovik
liat-grozovik merged commit 3145129 into sonic-net:master Oct 24, 2023
@keboliu
keboliu deleted the master_msn2700_syslog_file branch October 25, 2023 05:43
@keboliu

keboliu commented Oct 25, 2023

Copy link
Copy Markdown
Collaborator Author

@yxieca @StormLiangMS would you please help to cherry-pick?

mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Oct 25, 2023
- Why I did it
Mellanox MSN2700 platforms have a non-functional error log: "ERR pmon#sensord: Error getting sensor data: dps460/sonic-net#10: Can't read". This error is because of a firmware issue with some PSU, we are not able to upgrade the FW online. Since there is no functional impact, this error log can be ignored safely.

- How I did it
Add a new rsyslog rule to the rsyslog-container.conf.j2, if the docker name is pmon and the platform name matches, the new rule will be inserted into the docker rsyslogd.conf

- How to verify it
run regression on the MSN2700 platform to make the error log will not be printed to the syslog.

Signed-off-by: Kebo Liu <kebol@nvidia.com>
@mssonicbld

Copy link
Copy Markdown
Collaborator

@keboliu cherry pick PR didn't pass PR checker. Please check!!!
#17013

6 similar comments
@mssonicbld

Copy link
Copy Markdown
Collaborator

@keboliu cherry pick PR didn't pass PR checker. Please check!!!
#17013

@mssonicbld

Copy link
Copy Markdown
Collaborator

@keboliu cherry pick PR didn't pass PR checker. Please check!!!
#17013

@mssonicbld

Copy link
Copy Markdown
Collaborator

@keboliu cherry pick PR didn't pass PR checker. Please check!!!
#17013

@mssonicbld

Copy link
Copy Markdown
Collaborator

@keboliu cherry pick PR didn't pass PR checker. Please check!!!
#17013

@mssonicbld

Copy link
Copy Markdown
Collaborator

@keboliu cherry pick PR didn't pass PR checker. Please check!!!
#17013

@mssonicbld

Copy link
Copy Markdown
Collaborator

@keboliu cherry pick PR didn't pass PR checker. Please check!!!
#17013

@keboliu

keboliu commented Nov 1, 2023

Copy link
Copy Markdown
Collaborator Author

@keboliu cherry pick PR didn't pass PR checker. Please check!!!#17013

Hi, @StormLiangMS. It seems that some openssh version related fix is not included in the 202211 branch and are causing a build fail, would you please help to check?

@mssonicbld

Copy link
Copy Markdown
Collaborator

@keboliu cherry pick PR didn't pass PR checker. Please check!!!
#17013

1 similar comment
@mssonicbld

Copy link
Copy Markdown
Collaborator

@keboliu cherry pick PR didn't pass PR checker. Please check!!!
#17013

@StormLiangMS

StormLiangMS commented Nov 2, 2023

Copy link
Copy Markdown
Contributor

Hi @keboliu next time, pls have the tested branch info updated in the description part if need cherry pick to old branches.

mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Nov 2, 2023
- Why I did it
Mellanox MSN2700 platforms have a non-functional error log: "ERR pmon#sensord: Error getting sensor data: dps460/sonic-net#10: Can't read". This error is because of a firmware issue with some PSU, we are not able to upgrade the FW online. Since there is no functional impact, this error log can be ignored safely.

- How I did it
Add a new rsyslog rule to the rsyslog-container.conf.j2, if the docker name is pmon and the platform name matches, the new rule will be inserted into the docker rsyslogd.conf

- How to verify it
run regression on the MSN2700 platform to make the error log will not be printed to the syslog.

Signed-off-by: Kebo Liu <kebol@nvidia.com>
@mssonicbld

Copy link
Copy Markdown
Collaborator

Cherry-pick PR to 202305: #17078

@mssonicbld

Copy link
Copy Markdown
Collaborator

@keboliu cherry pick PR didn't pass PR checker. Please check!!!
#17013

4 similar comments
@mssonicbld

Copy link
Copy Markdown
Collaborator

@keboliu cherry pick PR didn't pass PR checker. Please check!!!
#17013

@mssonicbld

Copy link
Copy Markdown
Collaborator

@keboliu cherry pick PR didn't pass PR checker. Please check!!!
#17013

@mssonicbld

Copy link
Copy Markdown
Collaborator

@keboliu cherry pick PR didn't pass PR checker. Please check!!!
#17013

@mssonicbld

Copy link
Copy Markdown
Collaborator

@keboliu cherry pick PR didn't pass PR checker. Please check!!!
#17013

xdqi pushed a commit to canonical/sonic-buildimage that referenced this pull request Jul 6, 2026
- Why I did it
Mellanox MSN2700 platforms have a non-functional error log: "ERR pmon#sensord: Error getting sensor data: dps460/sonic-net#10: Can't read". This error is because of a firmware issue with some PSU, we are not able to upgrade the FW online. Since there is no functional impact, this error log can be ignored safely.

- How I did it
Add a new rsyslog rule to the rsyslog-container.conf.j2, if the docker name is pmon and the platform name matches, the new rule will be inserted into the docker rsyslogd.conf

- How to verify it
run regression on the MSN2700 platform to make the error log will not be printed to the syslog.

Signed-off-by: Kebo Liu <kebol@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants