[docker-quagga]: Use bgp keepalive and holdtime timers from configdb#1661
Merged
pavel-shirshov merged 1 commit intosonic-net:masterfrom Apr 30, 2018
pavel-shirshov:pavelsh/bgp_timers
Merged
[docker-quagga]: Use bgp keepalive and holdtime timers from configdb#1661pavel-shirshov merged 1 commit intosonic-net:masterfrom pavel-shirshov:pavelsh/bgp_timers
pavel-shirshov merged 1 commit intosonic-net:masterfrom
pavel-shirshov:pavelsh/bgp_timers
Conversation
rodnymolina
approved these changes
Apr 30, 2018
Contributor
rodnymolina
left a comment
rodnymolina
left a comment
There was a problem hiding this comment.
You may want to remove the extra spaces between 'if' and 'bgp_session'.
lguohan
approved these changes
Apr 30, 2018
FengPan-Frank
pushed a commit
to FengPan-Frank/sonic-buildimage
that referenced
this pull request
Dec 4, 2025
…tically (sonic-net#24232) #### Why I did it src/sonic-sairedis ``` * dcc3ac23 - (HEAD -> master, origin/master, origin/HEAD) Fix syncd crash due to attr obj list not initialized (sonic-net#1661) (11 hours ago) [Longxiang Lyu] ``` #### How I did it #### How to verify it #### Description for the changelog Signed-off-by: Feng Pan <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Add templates for using bgp neighbor timers into quagga bgpd template file.
- How I did it
Used data from configdb. If the timers values are default, don't put them into config, if not render new configuration
- How to verify it
Change configdb values directly in redis db
and then go into bgp docker and generate bgpd configuration by using the command:
- Description for the changelog
Generate bgpd quagga configuration for bgp per-neighbor timers.
- A picture of a cute animal (not mandatory but encouraged)