add minpoll&maxpoll in ntp.conf.j2 when generating ntp.conf#16369
Closed
bsun-sudo wants to merge 1 commit intosonic-net:masterfrom
Closed
add minpoll&maxpoll in ntp.conf.j2 when generating ntp.conf#16369bsun-sudo wants to merge 1 commit intosonic-net:masterfrom
bsun-sudo wants to merge 1 commit intosonic-net:masterfrom
Conversation
Collaborator
|
is there design doc? |
Contributor
Author
Hi @lguohan , create PR of updated NTP HLD to support NTP server minpoll & maxpoll configiruation. |
Contributor
Author
|
Close this PR. The change of this file is already in https://github.com/sonic-net/sonic-buildimage/pull/16310/files |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
When generating ntp.conf upon CONFIG_DB NTP_SERVER change, get the minpoll & maxpoll values from db entry and populate these in ntp.conf
PR to update NTP HLD is sonic-net/SONiC#1478
How I did it
Add the minpoll & maxpoll handling code in ntp.conf.j2
How to verify it
Use click ntp server add command with optional minpoll & maxpoll commands.
Verify ntp.conf is generated correctly.
unit tests results in PR sonic-net/sonic-utilities#2964