Skip to content

Dell S6100 component API fix#16363

Merged
lguohan merged 1 commit intosonic-net:masterfrom
aravindmani-1:s6100_api
Sep 19, 2023
Merged

Dell S6100 component API fix#16363
lguohan merged 1 commit intosonic-net:masterfrom
aravindmani-1:s6100_api

Conversation

@aravindmani-1
Copy link
Contributor

Why I did it

sonic-mgmt test failure is seen for update_firmware component API

How I did it

Edited API 2.0 to fix this issue.

How to verify it

Run sonic-mgmt test after the fix and verify it passes.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

@aravindmani-1 aravindmani-1 requested a review from lguohan as a code owner August 31, 2023 12:07
@aravindmani-1
Copy link
Contributor Author

we will support individual component upgrade once the request comes officially.

@lguohan lguohan merged commit 2f3f286 into sonic-net:master Sep 19, 2023
lguohan pushed a commit that referenced this pull request Sep 19, 2023
Why I did it
sonic-mgmt test failure is seen for update_firmware component API

Microsoft ADO: 25208748

How I did it
Edited API 2.0 to fix this issue.

How to verify it
Run sonic-mgmt test after the fix and verify it passes.
@prgeor
Copy link
Contributor

prgeor commented Sep 19, 2023

@StormLiangMS please cherry pick to 202305

sonic-otn pushed a commit to sonic-otn/sonic-buildimage that referenced this pull request Sep 20, 2023
Why I did it
sonic-mgmt test failure is seen for update_firmware component API

Microsoft ADO: 25208748

How I did it
Edited API 2.0 to fix this issue.

How to verify it
Run sonic-mgmt test after the fix and verify it passes.
@StormLiangMS
Copy link
Contributor

ADO: 24709430

mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Sep 21, 2023
Why I did it
sonic-mgmt test failure is seen for update_firmware component API

Microsoft ADO: 25208748

How I did it
Edited API 2.0 to fix this issue.

How to verify it
Run sonic-mgmt test after the fix and verify it passes.
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202305: #16613

@mssonicbld
Copy link
Collaborator

@aravindmani-1 PR conflicts with 202012 branch

mssonicbld pushed a commit that referenced this pull request Sep 21, 2023
Why I did it
sonic-mgmt test failure is seen for update_firmware component API

Microsoft ADO: 25208748

How I did it
Edited API 2.0 to fix this issue.

How to verify it
Run sonic-mgmt test after the fix and verify it passes.
@prgeor
Copy link
Contributor

prgeor commented Sep 24, 2023

@aravindmani-1 can you check if we need to cherry pick this to 202012? I see cherry pick conflict?

@aravindmani-1 aravindmani-1 deleted the s6100_api branch September 26, 2023 02:57
@aravindmani-1
Copy link
Contributor Author

@aravindmani-1 can you check if we need to cherry pick this to 202012? I see cherry pick conflict?

The fix is already available in 202012 branch.

@liuh-80
Copy link
Contributor

liuh-80 commented Sep 28, 2023

Add 202012 label because already included in 202012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants