Upgrade XGS saibcm-modules to 8.4#16246
Merged
StormLiangMS merged 11 commits intosonic-net:masterfrom Oct 26, 2023
Merged
Conversation
Gfrom2016
force-pushed
the
upgrade_sai_module
branch
3 times, most recently
from
86a3661 to
249a7ae
Compare
Gfrom2016
force-pushed
the
upgrade_sai_module
branch
2 times, most recently
from
731d836 to
c31a3f4
Compare
Gfrom2016
changed the title
saiarcot895
reviewed
Sep 26, 2023
Contributor
There was a problem hiding this comment.
This looks odd, I don't think this file should be used instead of what the system provides. @adyeung would you be able to comment on if this file needs to be present here for the kernel module build from SAI 8.4?
Contributor
There was a problem hiding this comment.
Hi @saiarcot895, These kernel headers were removed in PR #11709. Use the system psample headers and keep the "psample_sample_packet" call changes from PR #11709. These system header files were also removed in favor of kernel headers in a later version of SAI/SDK.
Collaborator
There was a problem hiding this comment.
@Gfrom2016 just to make sure this is clear, #11709 from Michael needs to take precedence over this submission, pls do the needful to honor #11709, otherwise the build will break.
Contributor
Author
There was a problem hiding this comment.
@saiarcot895 @michaelli10 and @adyeung, thanks for review this, I pushed another commit to honor #11709, please help review again, thanks
Contributor
|
Looks like the following header files that are newly added in this PR are not needed for compilation: I wonder if this should be removed, just to keep the number of files down? |
Contributor
Author
|
Signed-off-by: zitingguo-ms <zitingguo@microsoft.com>
Signed-off-by: zitingguo-ms <zitingguo@microsoft.com>
signed-off-by: zitingguo-ms <zitingguo@microsoft.com>
Signed-off-by: zitingguo-ms <zitingguo@microsoft.com>
Signed-off-by: zitingguo-ms <zitingguo@microsoft.com>
Signed-off-by: zitingguo-ms <zitingguo@microsoft.com>
Signed-off-by: zitingguo-ms <zitingguo@microsoft.com>
Signed-off-by: zitingguo-ms <zitingguo@microsoft.com>
Gfrom2016
force-pushed
the
upgrade_sai_module
branch
from
59d403f to
228a5b0
Compare
Collaborator
|
@michaelli10 @tushar-ty pls help review |
Signed-off-by: zitingguo-ms <zitingguo@microsoft.com>
michaelli10
reviewed
Oct 19, 2023
platform/broadcom/saibcm-modules/sdklt/linux/knetcb/psample-cb.c
Outdated
Show resolved
Hide resolved
platform/broadcom/saibcm-modules/systems/linux/kernel/modules/knet-cb/psample-cb.c
Outdated
Show resolved
Hide resolved
michaelli10
approved these changes
Oct 20, 2023
Contributor
|
@Gfrom2016 there is failure with semgrep, could you check? |
Contributor
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: zitingguo-ms <zitingguo@microsoft.com>
Gfrom2016
force-pushed
the
upgrade_sai_module
branch
from
62f921d to
a2c86b7
Compare
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Oct 26, 2023
Why I did it XGS saibcm-modules 8.4 is needed. sonic-net#14471 Work item tracking Microsoft ADO (number only): 24917414 How I did it Copy files from xgs SDK 8.4 repo and modify makefiles to build the image. Upgrade version to 8.4.0.2 in saibcm-modules.mk. How to verify it Build a private image and run full qualification with it: https://elastictest.org/scheduler/testplan/650419cb71f60aa92c456a2b
Collaborator
|
Cherry-pick PR to 202305: #17024 |
11 tasks
mssonicbld
added a commit
that referenced
this pull request
Oct 26, 2023
mssonicbld
added
Included in 202305 Branch
and removed
Created PR to 202305 Branch
labels
lukasstockner
added a commit
to genesiscloud/sonic-buildimage
that referenced
this pull request
Oct 31, 2023
This reverts commit 2c0f4e5.
lukasstockner
added a commit
to genesiscloud/sonic-buildimage
that referenced
this pull request
Oct 31, 2023
This reverts commit 2c0f4e5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
XGS saibcm-modules 8.4 is needed. #14471
Work item tracking
How I did it
Copy files from xgs SDK 8.4 repo and modify makefiles to build the image.
Upgrade version to 8.4.0.2 in saibcm-modules.mk.
How to verify it
Build a private image and run full qualification with it: https://elastictest.org/scheduler/testplan/650419cb71f60aa92c456a2b
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)
Signed-off-by: zitingguo-ms zitingguo@microsoft.com