Add yang model for PFC watchdog debug information#16206
Add yang model for PFC watchdog debug information#16206qiluo-msft merged 1 commit intosonic-net:masterfrom
Conversation
Signed-off-by: Stephen Sun <stephens@nvidia.com>
stephenxs
force-pushed
the
yang-model-pfcwd-enhance
branch
from
aae5ef4 to
6b9b26f
Compare
stephenxs
added
the
Request for 202111 Branch
### Why I did it When PFC WD is triggered there is no diagnosis information which makes it difficult to understand why PFC WD was triggered. So, we add a field `additional_information` to accommodate the diagnosis information. ### How to verify it unit test
stephenxs
added
Request for 202305 Branch
and removed
Request for 202111 Branch
|
@stephenxs did you run test with 202305 image with this PR? |
@StormLiangMS Yes, I did. This is to parse new field in PFC watchdog event introduced in PR sonic-net/sonic-swss#2858 |
### Why I did it When PFC WD is triggered there is no diagnosis information which makes it difficult to understand why PFC WD was triggered. So, we add a field `additional_information` to accommodate the diagnosis information. ### How to verify it unit test
|
Cherry-pick PR to 202305: #17008 |
mssonicbld
added
Included in 202305 Branch
and removed
Created PR to 202305 Branch
labels
|
Hi @stephenxs I am seeing issue in 202305 branch regarding this change, seems like additional_information value is not accounting for floating point values within the key value pairs. Seems like the yang will need to be updated to support that. "libyang[0]: Value "occupancy:0|packets:0|packets_last:0|pfc_rx_packets:0|pfc_rx_packets_last:0|pfc_duration:0|pfc_duration_last:0|timestamp:1709055546.5448|timestamp_last:1709055546.0438|real_poll_time:501045.94230652" does not satisfy the constraint "[-a-zA-Z0-9_]+:[-a-zA-Z0-9_]+(\|{1}[-a-zA-Z0-9_]+:[-a-zA-Z0-9_]+)*" Can you please update the yang model to support this and update testcase? |
Hi Zain |
5 participants
Why I did it
When PFC WD is triggered there is no diagnosis information which makes it difficult to understand why PFC WD was triggered. So, we add a field
additional_informationto accommodate the diagnosis information.Work item tracking
How I did it
How to verify it
unit test
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)