[Arista] Remove one pcie device from pcie.yaml accross platforms#16173
Merged
lguohan merged 1 commit intosonic-net:masterfrom Aug 23, 2023
Merged
[Arista] Remove one pcie device from pcie.yaml accross platforms#16173lguohan merged 1 commit intosonic-net:masterfrom
lguohan merged 1 commit intosonic-net:masterfrom
Conversation
These devices will not reliabily report the proper devid and vendorid when reading it is read directly from the pci config space. It can be read but shouldn't be compared against some fixed value like the one stored in pcie.yaml. Since this makes pcied unhappy, the simplest path forward is to just remove this device from monitoring.
Contributor
|
@Staphylo can we say that SCD device in question is not actually PCIe device since these are sitting on LPC bus? |
prgeor
approved these changes
Aug 22, 2023
Contributor
|
@yxieca please help merge. the build failure is not related to this change. |
lguohan
approved these changes
Aug 22, 2023
sonic-otn
pushed a commit
to sonic-otn/sonic-buildimage
that referenced
this pull request
Sep 20, 2023
These devices will not reliabily report the proper devid and vendorid when reading it is read directly from the pci config space. It can be read but shouldn't be compared against some fixed value like the one stored in pcie.yaml. Since this makes pcied unhappy, the simplest path forward is to just remove this device from monitoring.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
These devices will not reliabily report the proper devid and vendorid when reading it is read directly from the pci config space. It can be read but shouldn't be compared against some fixed value like the one stored in pcie.yaml.
Work item tracking
How I did it
Since this makes pcied unhappy, the simplest path forward is to just remove this device from monitoring.
How to verify it
The pcied periodic read from pci config space no longer complains.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Remove one pcie device from pcie.yaml accross Arista platforms