Skip to content

[docker-syncd-brcm]: start.sh returns 0 when exit normally #1608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lguohan wants to merge 1 commit into from
Closed

[docker-syncd-brcm]: start.sh returns 0 when exit normally #1608

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions platform/broadcom/docker-syncd-brcm/start.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,3 +35,5 @@ if [ -r ${PLATFORM_DIR}/led_proc_init.soc ]; then
wait_syncd
/usr/bin/bcmcmd -t 60 "rcload ${PLATFORM_DIR}/led_proc_init.soc"
Copy link
Collaborator

@qiluo-msft qiluo-msft Apr 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bcmcmd [](start = 13, length = 6)

If I understand it correctly, you are fixing for the case 'bcmcmd' timeout. If yes, better fix it by 'bcmcmd || true', indicating any error is ok.

Further more, is it possible to run a bcm command async? like 'rcload &' in bash?

fi

exit 0