[Mellanox] Remove unnecessary file manipulation in the SAI Make file#15993
Merged
liat-grozovik merged 1 commit intosonic-net:masterfrom Aug 3, 2023
Merged
Conversation
Signed-off-by: Kebo Liu <[email protected]>
Junchao-Mellanox
approved these changes
Jul 31, 2023
liat-grozovik
approved these changes
Aug 3, 2023
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Aug 6, 2023
…sonic-net#15993) Signed-off-by: Kebo Liu <[email protected]>
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Aug 6, 2023
…sonic-net#15993) Signed-off-by: Kebo Liu <[email protected]>
Collaborator
|
Cherry-pick PR to 202305: #16043 |
Collaborator
|
Cherry-pick PR to 202211: #16044 |
mssonicbld
added a commit
that referenced
this pull request
Aug 6, 2023
mssonicbld
added
Included in 202211 Branch
and removed
Approved for 202211 Branch
Created PR to 202211 Branch
labels
mssonicbld
added a commit
that referenced
this pull request
Aug 6, 2023
mssonicbld
added
Included in 202305 Branch
and removed
Created PR to 202305 Branch
labels
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Aug 10, 2023
…sonic-net#15993) Signed-off-by: Kebo Liu <[email protected]>
Collaborator
|
Cherry-pick PR to 202205: #16101 |
Merged
11 tasks
yxieca
pushed a commit
that referenced
this pull request
Aug 11, 2023
…#15993) (#16101) Signed-off-by: Kebo Liu <[email protected]> Co-authored-by: Kebo Liu <[email protected]>
mssonicbld
added
Included in 202205 Branch
and removed
Approved for 202205 Branch
Created PR to 202205 Branch
labels
sonic-otn
pushed a commit
to sonic-otn/sonic-buildimage
that referenced
this pull request
Sep 20, 2023
…sonic-net#15993) Signed-off-by: Kebo Liu <[email protected]>
Junchao-Mellanox
pushed a commit
to noaOrMlnx/sonic-buildimage
that referenced
this pull request
Sep 22, 2023
…sonic-net#15993) Signed-off-by: Kebo Liu <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
There is an unnecessary file manipulation in the SAI make file, "chmod a+x autogen.sh", however file "autogen.sh" has never been executed during SAI binary building, so it shall be removed.
At the same time, in the new SAI code, "autogen.sh" has been deleted since it's not needed anymore, if keep this line will cause build failure when upgrading to the new SAI.
Work item tracking
How I did it
Remove the unnecessary line in the Make file
How to verify it
Make a Mellanox SONiC image, and make sure SAI can be built and installed correctly.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)