[YANG] add `MUX_LINKMGR|SERVICE_MGMT` by zjswhhh · Pull Request #15927 · sonic-net/sonic-buildimage

zjswhhh · 2023-07-20T23:27:53Z

Adding yang model for CONFIG_DB table MUX_LINKMGR|SERVICE_MGMT.

sign-off: Jing Zhang zhangjing@microsoft.com

Why I did it

Work item tracking

Microsoft ADO (number only): 18445751

How I did it

How to verify it

==================================================================================== test session starts ====================================================================================
platform linux -- Python 3.9.2, pytest-6.0.2, py-1.10.0, pluggy-0.13.0
rootdir: /sonic/src/sonic-yang-models
plugins: pyfakefs-5.2.3, cov-2.10.1
collected 3 items                                                                                                                                                                           

tests/test_sonic_yang_models.py ..                                                                                                                                                    [ 66%]
tests/yang_model_tests/test_yang_model.py .                                                                                                                                           [100%]

===================================================================================== 3 passed in 2.06s =====================================================================================

Which release branch to backport (provide reason below if selected)

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

ganglyu · 2023-08-01T22:38:46Z

src/sonic-yang-models/yang-models/sonic-mux-linkmgr.yang

+            container SERVICE_MGMT {
+
+                leaf kill_radv {
+                    type enumeration {


Please use boolean instead.

sonic-buildimage/files/scripts/service_mgmt.sh

Lines 43 to 46 in ea34cb2

CONFIG_KNOB=`$SONIC_DB_CLI CONFIG_DB hget "MUX_LINKMGR|SERVICE_MGMT" kill_radv`

if [[ x"$CONFIG_KNOB" == x"False" ]]; then

ACTIVE_ACTIVE='false'

fi

Hi Gang - we have capitalized letters so I can't make the field as boolean.

mssonicbld · 2023-08-02T21:42:22Z

@zjswhhh PR conflicts with 202211 branch

mssonicbld · 2023-08-02T21:42:23Z

@zjswhhh PR conflicts with 202205 branch

mssonicbld · 2023-08-06T14:46:24Z

@zjswhhh PR conflicts with 202305 branch

yxieca · 2023-08-07T16:52:54Z

Need to cherry-pick #15884 first.

Adding yang model for CONFIG_DB table MUX_LINKMGR|SERVICE_MGMT. sign-off: Jing Zhang zhangjing@microsoft.com

mssonicbld · 2023-08-07T16:53:32Z

Cherry-pick PR to 202205: #16070

mssonicbld · 2023-08-07T16:53:38Z

@zjswhhh PR conflicts with 202211 branch

Adding yang model for CONFIG_DB table MUX_LINKMGR|SERVICE_MGMT. sign-off: Jing Zhang zhangjing@microsoft.com

mssonicbld · 2023-08-07T16:56:45Z

Cherry-pick PR to 202211: #16071

Adding yang model for CONFIG_DB table MUX_LINKMGR|SERVICE_MGMT. sign-off: Jing Zhang zhangjing@microsoft.com Co-authored-by: Jing Zhang <zhangjing@microsoft.com>

Adding yang model for CONFIG_DB table MUX_LINKMGR|SERVICE_MGMT. sign-off: Jing Zhang zhangjing@microsoft.com

mssonicbld · 2023-08-14T06:34:53Z

Cherry-pick PR to 202305: #16138

Adding yang model for CONFIG_DB table MUX_LINKMGR|SERVICE_MGMT. sign-off: Jing Zhang zhangjing@microsoft.com

add service_mgmt

5fa667d

zjswhhh requested a review from qiluo-msft as a code owner July 20, 2023 23:27

zjswhhh requested review from ganglyu and yxieca July 20, 2023 23:28

yxieca approved these changes Jul 21, 2023

View reviewed changes

zjswhhh added YANG YANG model related changes Request for 202205 Branch Request for 202305 Branch Request for 202211 Branch labels Jul 25, 2023

ganglyu reviewed Aug 1, 2023

View reviewed changes

yxieca merged commit b23ec06 into sonic-net:master Aug 2, 2023

yxieca added Approved for 202205 Branch Approved for 202211 Branch labels Aug 2, 2023

mssonicbld added Cherry Pick Conflict_202211 Cherry Pick Conflict_202205 labels Aug 2, 2023

StormLiangMS added the Approved for 202305 Branch label Aug 6, 2023

mssonicbld added the Cherry Pick Conflict_202305 label Aug 6, 2023

yxieca removed Cherry Pick Conflict_202205 Approved for 202205 Branch Approved for 202211 Branch Cherry Pick Conflict_202211 Approved for 202305 Branch Cherry Pick Conflict_202305 labels Aug 7, 2023

yxieca added Approved for 202205 Branch Approved for 202211 Branch labels Aug 7, 2023

mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Aug 7, 2023

add service_mgmt (sonic-net#15927)

a27cd7a

Adding yang model for CONFIG_DB table MUX_LINKMGR|SERVICE_MGMT. sign-off: Jing Zhang zhangjing@microsoft.com

mssonicbld mentioned this pull request Aug 7, 2023

[action] [PR:15927] [YANG] add MUX_LINKMGR|SERVICE_MGMT #16070

Merged

11 tasks

mssonicbld added the Cherry Pick Conflict_202211 label Aug 7, 2023

yxieca added Approved for 202211 Branch and removed Approved for 202211 Branch Cherry Pick Conflict_202211 labels Aug 7, 2023

mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Aug 7, 2023

add service_mgmt (sonic-net#15927)

cda517b

Adding yang model for CONFIG_DB table MUX_LINKMGR|SERVICE_MGMT. sign-off: Jing Zhang zhangjing@microsoft.com

mssonicbld added the Created PR to 202211 Branch label Aug 7, 2023

mssonicbld mentioned this pull request Aug 7, 2023

[action] [PR:15927] [YANG] add MUX_LINKMGR|SERVICE_MGMT #16071

Merged

11 tasks

zjswhhh deleted the service_mgmt_master branch August 7, 2023 17:41

yxieca pushed a commit that referenced this pull request Aug 10, 2023

add service_mgmt (#15927) (#16070)

c2a7dd1

Adding yang model for CONFIG_DB table MUX_LINKMGR|SERVICE_MGMT. sign-off: Jing Zhang zhangjing@microsoft.com Co-authored-by: Jing Zhang <zhangjing@microsoft.com>

mssonicbld added Included in 202205 Branch and removed Approved for 202205 Branch Created PR to 202205 Branch labels Aug 10, 2023

StormLiangMS added the Approved for 202305 Branch label Aug 14, 2023

mssonicbld added the Created PR to 202305 Branch label Aug 14, 2023

mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Aug 14, 2023

add service_mgmt (sonic-net#15927)

988af62

Adding yang model for CONFIG_DB table MUX_LINKMGR|SERVICE_MGMT. sign-off: Jing Zhang zhangjing@microsoft.com

mssonicbld mentioned this pull request Aug 14, 2023

[action] [PR:15927] [YANG] add MUX_LINKMGR|SERVICE_MGMT #16138

Merged

11 tasks

mssonicbld pushed a commit that referenced this pull request Aug 16, 2023

add service_mgmt (#15927)

0352c83

Adding yang model for CONFIG_DB table MUX_LINKMGR|SERVICE_MGMT. sign-off: Jing Zhang zhangjing@microsoft.com

mssonicbld pushed a commit that referenced this pull request Aug 16, 2023

add service_mgmt (#15927)

25662c6

Adding yang model for CONFIG_DB table MUX_LINKMGR|SERVICE_MGMT. sign-off: Jing Zhang zhangjing@microsoft.com

mssonicbld added Included in 202305 Branch Included in 202211 Branch and removed Created PR to 202305 Branch Approved for 202211 Branch Created PR to 202211 Branch labels Aug 16, 2023

sonic-otn pushed a commit to sonic-otn/sonic-buildimage that referenced this pull request Sep 20, 2023

add service_mgmt (sonic-net#15927)

25121e2

Adding yang model for CONFIG_DB table MUX_LINKMGR|SERVICE_MGMT. sign-off: Jing Zhang zhangjing@microsoft.com

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[YANG] add `MUX_LINKMGR|SERVICE_MGMT`#15927

[YANG] add `MUX_LINKMGR|SERVICE_MGMT`#15927
yxieca merged 1 commit intosonic-net:masterfrom
zjswhhh:service_mgmt_master

zjswhhh commented Jul 20, 2023 •

edited

Loading

Uh oh!

ganglyu Aug 1, 2023

Uh oh!

zjswhhh Aug 1, 2023

Uh oh!

mssonicbld commented Aug 2, 2023

Uh oh!

mssonicbld commented Aug 2, 2023

Uh oh!

mssonicbld commented Aug 6, 2023

Uh oh!

yxieca commented Aug 7, 2023

Uh oh!

mssonicbld commented Aug 7, 2023

Uh oh!

mssonicbld commented Aug 7, 2023

Uh oh!

mssonicbld commented Aug 7, 2023

Uh oh!

mssonicbld commented Aug 14, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

	CONFIG_KNOB=`$SONIC_DB_CLI CONFIG_DB hget "MUX_LINKMGR\|SERVICE_MGMT" kill_radv`
	if [[ x"$CONFIG_KNOB" == x"False" ]]; then
	ACTIVE_ACTIVE='false'
	fi

Conversation

zjswhhh commented Jul 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why I did it

Work item tracking

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Uh oh!

ganglyu Aug 1, 2023

Choose a reason for hiding this comment

Uh oh!

zjswhhh Aug 1, 2023

Choose a reason for hiding this comment

Uh oh!

mssonicbld commented Aug 2, 2023

Uh oh!

mssonicbld commented Aug 2, 2023

Uh oh!

mssonicbld commented Aug 6, 2023

Uh oh!

yxieca commented Aug 7, 2023

Uh oh!

mssonicbld commented Aug 7, 2023

Uh oh!

mssonicbld commented Aug 7, 2023

Uh oh!

mssonicbld commented Aug 7, 2023

Uh oh!

mssonicbld commented Aug 14, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

zjswhhh commented Jul 20, 2023 •

edited

Loading