[action] [PR:15896] [master] Mellanox: 2700, 4600c - Quoted device IDs to prevent false flags in pcied#15909
Closed
mssonicbld wants to merge 1 commit intosonic-net:202205from
Closed
[action] [PR:15896] [master] Mellanox: 2700, 4600c - Quoted device IDs to prevent false flags in pcied#15909mssonicbld wants to merge 1 commit intosonic-net:202205from
mssonicbld wants to merge 1 commit intosonic-net:202205from
Conversation
…lags in pcied (sonic-net#15896) Why I did it Certain all-numeric device IDs of PCI devices in the pcie.yaml file are left unquoted, leading to false mismatch flags in the pcie daemon and subsequently leads to log flooding. This PR fixes that issue. Work item tracking Microsoft ADO (number only): 24578930 How I did it Added quotes around numeric PCI devices in the pcie.yaml files of the following platforms: x86_64-mlnx_msn2700-r0 x86_64-mlnx_msn4600c-r0 How to verify it Install latest image after the merge and verify that syslogs are not flooded with PCI device mismatch errors
11 tasks
Collaborator
Author
|
Original PR: #15896 |
Contributor
|
The feature caused issue has been reverted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Certain all-numeric device IDs of PCI devices in the pcie.yaml file are left unquoted, leading to false mismatch flags in the pcie daemon and subsequently leads to log flooding. This PR fixes that issue.
Work item tracking
How I did it
Added quotes around numeric PCI devices in the pcie.yaml files of the following platforms:
x86_64-mlnx_msn2700-r0
x86_64-mlnx_msn4600c-r0
How to verify it
Install latest image after the merge and verify that syslogs are not flooded with PCI device mismatch errors
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Quoted device IDs to prevent false flags in pcied
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)