[Build][202012] Fix the PyYang python package installation issue (#15890)#15903
Merged
xumia merged 5 commits intosonic-net:202012from Jul 23, 2023
Merged
[Build][202012] Fix the PyYang python package installation issue (#15890)#15903xumia merged 5 commits intosonic-net:202012from
xumia merged 5 commits intosonic-net:202012from
Conversation
…5890) Why I did it Fix the armhf build failure. How to reproduce the issue: docker run -it debain:bullseye bash apt-get update && apt-get install -y python3-pip pip3 install PyYAML==5.4.1 Error message: Collecting PyYAML==5.4.1 Installing build dependencies ... done Getting requirements to build wheel ... error ERROR: Command errored out with exit status 1: command: /usr/bin/python3 /tmp/tmp6xabslgb_in_process.py get_requires_for_build_wheel /tmp/tmp_er01ztl .... raise AttributeError(attr) AttributeError: cython_sources ---------------------------------------- WARNING: Discarding https://files.pythonhosted.org/packages/a0/a4/d63f2d7597e1a4b55aa3b4d6c5b029991d3b824b5bd331af8d4ab1ed687d/PyYAML-5.4.1.tar.gz#sha256=607774cbba28732bfa802b54baa7484215f530991055bb562efbed5b2f20a45e (from https://pypi.org/simple/pyyaml/) (requires-python:>=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*, !=3.4.*, !=3.5.*). Command errored out with exit status 1: /usr/bin/python3 /tmp/tmp6xabslgb_in_process.py get_requires_for_build_wheel /tmp/tmp_er01ztl Check the logs for full command output. ERROR: Could not find a version that satisfies the requirement PyYAML==5.4.1 ERROR: No matching distribution found for PyYAML==5.4.1 root@fa2fa92edcfd:/# But if adding the option --no-build-isolation, then it is good, see fix. install "PyYAML==5.4.1" --no-build-isolation The same error can be found in the multiple builds. Work item tracking Microsoft ADO (number only): 24567457 How I did it Add a build option --no-build-isolation.
xumia
changed the title
Contributor
|
@xumia , the task #24567457 missing 202012 tag, please update. |
Collaborator
Author
Added, thanks. |
qiluo-msft
approved these changes
Jul 19, 2023
|
/easycla |
Collaborator
Author
|
For 202012, the python2 in some of the docker images and host image, need to add additional patches for it. |
qiluo-msft
reviewed
Jul 22, 2023
| # The option --no-build-isolation can be removed when upgrading PyYAML to 6.0.1 | ||
| # The the PyYAML for python3 has already installed in the base image docker-config-engine | ||
| RUN pip2 install wheel==0.37.1 | ||
| RUN pip2 install PyYAML==5.4.1 --no-build-isolation |
Collaborator
Collaborator
Author
There was a problem hiding this comment.
The python2 is not installed in docker-config-engine-buster, only in docker-platform-monitor and docker-sonic-mgmt-framework.
qiluo-msft
reviewed
Jul 22, 2023
| RUN apt-get purge -y python-pip | ||
| RUN pip2 install setuptools==40.8.0 | ||
| RUN pip2 install wheel==0.35.1 | ||
| RUN pip2 install PyYAML==5.4.1 --no-build-isolation |
Collaborator
Collaborator
Author
There was a problem hiding this comment.
In docker-config-engine-buster only for python3, no python2.
qiluo-msft
approved these changes
Jul 22, 2023
centecqianj
pushed a commit
to CentecNetworks/sonic-buildimage
that referenced
this pull request
Dec 21, 2023
…ic-net#15890) (sonic-net#15903) * [Build] Fix the PyYang python package installation issue (sonic-net#15890) Why I did it Fix the armhf build failure. How to reproduce the issue: docker run -it debain:bullseye bash apt-get update && apt-get install -y python3-pip pip3 install PyYAML==5.4.1 Error message: Collecting PyYAML==5.4.1 Installing build dependencies ... done Getting requirements to build wheel ... error ERROR: Command errored out with exit status 1: command: /usr/bin/python3 /tmp/tmp6xabslgb_in_process.py get_requires_for_build_wheel /tmp/tmp_er01ztl .... raise AttributeError(attr) AttributeError: cython_sources ---------------------------------------- WARNING: Discarding https://files.pythonhosted.org/packages/a0/a4/d63f2d7597e1a4b55aa3b4d6c5b029991d3b824b5bd331af8d4ab1ed687d/PyYAML-5.4.1.tar.gz#sha256=607774cbba28732bfa802b54baa7484215f530991055bb562efbed5b2f20a45e (from https://pypi.org/simple/pyyaml/) (requires-python:>=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*, !=3.4.*, !=3.5.*). Command errored out with exit status 1: /usr/bin/python3 /tmp/tmp6xabslgb_in_process.py get_requires_for_build_wheel /tmp/tmp_er01ztl Check the logs for full command output. ERROR: Could not find a version that satisfies the requirement PyYAML==5.4.1 ERROR: No matching distribution found for PyYAML==5.4.1 root@fa2fa92edcfd:/# But if adding the option --no-build-isolation, then it is good, see fix. install "PyYAML==5.4.1" --no-build-isolation The same error can be found in the multiple builds. Work item tracking Microsoft ADO (number only): 24567457 How I did it Add a build option --no-build-isolation. * Fix docker-platform-monitor python2 issue * Fix wheel dependency issue * Fix wheel dependency issue * Fix the pip2 PyYAML in host image
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Cherry pick from PR: #15890
Fix the armhf build failure.
How to reproduce the issue:
Error message:
But if adding the option --no-build-isolation, then it is good, see fix.
The same error can be found in the multiple builds.
Work item tracking
How I did it
Add a build option --no-build-isolation.
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)