[staticroutebfd] fix ipv6 letter case issue#15765
Merged
prsunny merged 1 commit intosonic-net:masterfrom Jul 10, 2023
baorliu:cisco-baorliu-fix-srtbfd-15764
Merged
[staticroutebfd] fix ipv6 letter case issue#15765prsunny merged 1 commit intosonic-net:masterfrom baorliu:cisco-baorliu-fix-srtbfd-15764
prsunny merged 1 commit intosonic-net:masterfrom
baorliu:cisco-baorliu-fix-srtbfd-15764
Conversation
use lower case for IPv6 address as internal key and bfd session key.
5 tasks
abdosi
approved these changes
Jul 10, 2023
Contributor
|
@prsunny can you help merge with this. |
sonic-otn
pushed a commit
to sonic-otn/sonic-buildimage
that referenced
this pull request
Sep 20, 2023
*use lower case for IPv6 address as internal key and bfd session key. fixes sonic-net#15764 Why I did it *staticroutebfd uses the IPv6 address string as a key to create bfd session and cache the bfd sessions using it as a key. When the IPv6 address string has uppercase letter in the static route nexthop list, the string with uppercase letter key is stored in the cache, but the BFD STATE_DB uses lowercase for IPv6 address, so when the staticroutebfd get the bfd state event, it cannot find the bfd session in its local cache because of the letter case.
Contributor
|
@abdosi , This is required in 202305. Thanks |
Contributor
|
@StormLiangMS please help with cherry-pick for 202305. |
Contributor
|
@abdosi could you have ADO to support this cherry pick? |
Contributor
@StormLiangMS this is needed. ADO updated. |
StormLiangMS
added
Approved for 202305 Branch
and removed
Approved for 202305 Branch
labels
Contributor
This was referenced Jan 31, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Feb 1, 2024
*use lower case for IPv6 address as internal key and bfd session key. fixes sonic-net#15764 Why I did it *staticroutebfd uses the IPv6 address string as a key to create bfd session and cache the bfd sessions using it as a key. When the IPv6 address string has uppercase letter in the static route nexthop list, the string with uppercase letter key is stored in the cache, but the BFD STATE_DB uses lowercase for IPv6 address, so when the staticroutebfd get the bfd state event, it cannot find the bfd session in its local cache because of the letter case.
Collaborator
|
Cherry-pick PR to 202305: #17981 |
Contributor
mssonicbld
pushed a commit
that referenced
this pull request
Feb 3, 2024
*use lower case for IPv6 address as internal key and bfd session key. fixes #15764 Why I did it *staticroutebfd uses the IPv6 address string as a key to create bfd session and cache the bfd sessions using it as a key. When the IPv6 address string has uppercase letter in the static route nexthop list, the string with uppercase letter key is stored in the cache, but the BFD STATE_DB uses lowercase for IPv6 address, so when the staticroutebfd get the bfd state event, it cannot find the bfd session in its local cache because of the letter case.
anamehra
added a commit
to anamehra/sonic-buildimage
that referenced
this pull request
Feb 3, 2024
This reverts commit 630d93e.
lixiaoyuner
pushed a commit
to lixiaoyuner/sonic-buildimage
that referenced
this pull request
Feb 6, 2024
…sonic-buildimage into internal Fix conflict for rsyslog. Skip partial DNS unit test in internal branch after confirmed with Gang. Related work items: sonic-net#113, sonic-net#131, sonic-net#132, sonic-net#134, sonic-net#321, sonic-net#331, sonic-net#381, sonic-net#382, sonic-net#2525, sonic-net#2676, sonic-net#2698, sonic-net#2737, sonic-net#2789, sonic-net#2839, sonic-net#2845, sonic-net#2850, sonic-net#2882, sonic-net#2885, sonic-net#2887, sonic-net#2890, sonic-net#2895, sonic-net#13338, sonic-net#14105, sonic-net#15142, sonic-net#15223, sonic-net#15456, sonic-net#15487, sonic-net#15520, sonic-net#15726, sonic-net#15727, sonic-net#15758, sonic-net#15764, sonic-net#15765, sonic-net#15772, sonic-net#15779, sonic-net#15782, sonic-net#15785, sonic-net#15797, sonic-net#15798, sonic-net#15810, sonic-net#15811, sonic-net#15821
StormLiangMS
pushed a commit
that referenced
this pull request
Feb 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use lower case for IPv6 address as internal key and bfd session key.
fixes #15764
Why I did it
staticroutebfd uses the IPv6 address string as a key to create bfd session and cache the bfd sessions using it as a key.
When the IPv6 address string has uppercase letter in the static route nexthop list, the string with uppercase letter key is stored in the cache, but the BFD STATE_DB uses lowercase for IPv6 address, so when the staticroutebfd get the bfd state event, it cannot find the bfd session in its local cache because of the letter case.
Work item tracking
How I did it
convert the IPv6 address string to lower case inside the staticroutebfd, and use the lowercase address to create BFD session.
How to verify it
Verified it both in UT and testbed.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)