[202012] dhcprelay add Loopback0 as source interface in dualtor scenario #15744
Merged
qiluo-msft merged 4 commits intosonic-net:202012from Jul 25, 2023
jcaiMR:dev/jcai_202012_dhcprelay_dualtor
Merged
[202012] dhcprelay add Loopback0 as source interface in dualtor scenario #15744qiluo-msft merged 4 commits intosonic-net:202012from jcaiMR:dev/jcai_202012_dhcprelay_dualtor
qiluo-msft merged 4 commits intosonic-net:202012from
jcaiMR:dev/jcai_202012_dhcprelay_dualtor
Conversation
kellyyeh
approved these changes
Jul 10, 2023
added 2 commits
July 11, 2023 09:14
…/sonic-buildimage into dev/jcai_202012_dhcprelay_dualtor
Contributor
Author
|
@yxieca Hi Ying, would you please help approval and merge this PR. |
yxieca
approved these changes
Jul 12, 2023
Collaborator
|
@jcaiMR Why there is no fix on master branch? If there should one, we need to fix master first, and backport to 202012 and later branches. |
Contributor
Author
In 202012, dhcp_relay use different branch, the code base is huge different compare with master, so we have to use another PR for solution not cherry pick. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
sonic-build image side change to fix source interface selection in dual tor scenario.
dhcprelay related PR:
[202012] fix dual-tor relay-reply handing issue sonic-dhcp-relay#40
Announce dhcprelay submodule to 3578eb3 (to invoke #40 PR)
Work item tracking
How I did it
How to verify it
run test case, dhcp_relay/test_dhcpv6_relay.py
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)