[action] [PR:14814] [chassis][lldp] Fix the lldp error log in host instance which doesn't contain front panel ports#15603
Merged
mssonicbld merged 1 commit intosonic-net:202305from Jun 29, 2023
Conversation
10 tasks
Collaborator
Author
|
Original PR: #14814 |
gechiang
approved these changes
Jun 23, 2023
… contain front panel ports (sonic-net#14814) * [chassis][lldp] Fix the lldp error log in host instance which doesn't contain front pannel ports --------- Signed-off-by: mlok <[email protected]>
mssonicbld
force-pushed
the
cherry/202305/14814
branch
from
b46bf35 to
78ba433
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Fix issue #14251
In multiasic platform, there is NO front panel port in the host lldp docker. Because of there is NO front panel port, the host APPL_DB database will not genernate the "PORT_CONFIG_DONE" and "PORT_INIT_DONE" event. Therefore, the lldpmgrd log the error log -
Port init timeout reached (300 seconds), resuming lldpd...in syslog.OC test case failed-- autorestart/test_container_autorestart.py::test_containers_autorestart[ixre-cpm-chassis9-10-snmp
Work item tracking
How I did it
Since there is NO front panel ports in the host database in the multiasic platform , there won't be PORT_CONFIG_DONE and PORT_INIT_DONE event from the APPL_DB. The error log ``Port init timeout reached (300 seconds), resuming lldpd...``` is not applicable to the host lldp. In or to suppress this error message, add function appdb_contains_lldp_port() to return False for the supervisor card and host instance in the multasic platform which NAMESPACE_ID is none. And use this function to determine and not to log this error log for the supervisor card and host database in the multasic platform.
How to verify it
Running image with this fix in the multiasic platform, verify this error log
Port init timeout reached (300 seconds), resuming lldpd...should not be logged in the syslog.Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)