Ensure sonic yangs wheel is built before sonic-mgmt-common#15226
Merged
Praveen-Brcm merged 2 commits intosonic-net:masterfrom Aug 9, 2023
Merged
Ensure sonic yangs wheel is built before sonic-mgmt-common#15226Praveen-Brcm merged 2 commits intosonic-net:masterfrom
Praveen-Brcm merged 2 commits intosonic-net:masterfrom
Conversation
Collaborator
|
@qiluo-msft @xumia pls help review the change, this is needed to address the community issue #15183 |
* Enhanced slave.mk to accept python wheels as dependency for a deb
target. Dependent wheel names should be specified through the new
{deb_name}_WHEEL_DEPENDS variable in the deb's make rules. The wheel
will be built and installed in the slave docker before starting the
deb build.
* Added sonic_yang_models-1.0-py3-none-any.whl as dependency for
sonic-mgmt-common.deb. This is required for using the sonic yangs in
UMF
Signed-off-by: Sachin Holla <[email protected]>
kwangsuk
approved these changes
Aug 8, 2023
anand-kumar-subramanian
approved these changes
Aug 8, 2023
Collaborator
|
@qiluo-msft @xumia got review approval from Kwan and Anand, will merge tomorrow if there is no further comments |
qiluo-msft
approved these changes
Aug 9, 2023
sonic-otn
pushed a commit
to sonic-otn/sonic-buildimage
that referenced
this pull request
Sep 20, 2023
…#15226) * Enhanced slave.mk to accept python wheels as dependency for a deb target. Dependent wheel names should be specified through the new {deb_name}_WHEEL_DEPENDS variable in the deb's make rules. The wheel will be built and installed in the slave docker before starting the deb build. * Added sonic_yang_models-1.0-py3-none-any.whl as dependency for sonic-mgmt-common.deb. This is required for using the sonic yangs in UMF Signed-off-by: Sachin Holla <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
We plan to enhance UMF to import sonic yangs from the sonic-yang-models directory. Today UMF consumes yangs maintained in sonic-mgmt-commom repo only. UMF runs multiple code generators on these yangs during build time. . sonic-yang-models also has build time templating. Hence for sonic-mgmt-common builds use the yangs from sonic-yang-models, the sonic_yang_models-1.0-py3-none-any.whl must be built fist.
Required for addressing the issue #15183
Work item tracking
How I did it
Enhanced slave.mk to accept python wheels as dependency for a deb target. Dependent wheel names should be specified through the new {deb_name}_WHEEL_DEPENDS variable in the deb's make rules. The wheel will be built and installed in the slave docker before starting the deb build.
Added sonic_yang_models-1.0-py3-none-any.whl as dependency for sonic-mgmt-common.deb. This is required for using the sonic yangs in UMF
How to verify it
Build only sonic-mgmt-common debian package as well as full image.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)