[device/dell] Added dynamic sai.profile generation#1518
Merged
yxieca merged 2 commits intosonic-net:masterfrom Mar 21, 2018
Merged
[device/dell] Added dynamic sai.profile generation#1518yxieca merged 2 commits intosonic-net:masterfrom
yxieca merged 2 commits intosonic-net:masterfrom
Conversation
This commit addds new code for generating dynamic sai.profile file. The sai.profile.j2 will generate the sai.profile dynamically based on the topology. It will generate the sai.profile under /etc/sai.d/ directory in syncd. Before syncd is started this J2 file will be run from the start.sh file from /usr/bin/ directory. Since the sai.profile is dynamically generated the old sai.profile file is not required so deleted the file for S6100. It also address couple of more changes for port_config.ini support is added for speed in the file which can be used later to find the port speed. Also the buffer_default_t*.j2 file the ports should be from 0 to 64 changed. Unit tested the code on S6100 for dynamic generation of sai.profile file for both T0 and T1 and the file was created in /etc/sai.d/sai.profile Similarly tested the sonic binary on S6000 to make sure that the sai.profile is copied from the /usr/share/sonic/hwsku/sai.profile to /etc/sai.d/sai.profile. Signed-off-by: Harish Venkatraman <Harish_Venkatraman@dell.com>
Contributor
Author
|
@yxieca Can you please review the changes. |
Contributor
|
You need to make swss change first, and add submodule update to this review. |
yxieca
reviewed
Mar 20, 2018
Contributor
There was a problem hiding this comment.
Can you remove this empty line?
yxieca
reviewed
Mar 20, 2018
Contributor
There was a problem hiding this comment.
s/sai_profile_filename/sai_profile_contents/
yxieca
reviewed
Mar 21, 2018
Contributor
yxieca
left a comment
yxieca
left a comment
There was a problem hiding this comment.
Please fix a couple minor issues. The rest looks pretty good.
Thanks,
Ying
Updating the sonic-sairedis point. Signed-off-by: Harish Venkatraman <Harish_Venkatraman@dell.com>
vharish02
force-pushed
the
dynamic_sai_profile
branch
from
a3e631f to
07ba665
Compare
Contributor
Author
|
@yxieca All minor changes done. |
yxieca
approved these changes
Mar 21, 2018
abdosi
added a commit
to abdosi/sonic-buildimage
that referenced
this pull request
Dec 4, 2020
17adc13 (HEAD -> 201911, origin/201911) Add a check for warm-restart, and do a clear only when warm-restart is enable. (sonic-net#1498) d097260 Fixed compilation failure with debug option (sonic-net#1518) Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
abdosi
added a commit
that referenced
this pull request
Dec 4, 2020
abdosi
added a commit
that referenced
this pull request
Dec 15, 2020
7f50b98 (HEAD -> 201911, origin/201911) handled update() function of fdb orchagent for FDB FLUSH event (#1534) 17adc13 Add a check for warm-restart, and do a clear only when warm-restart is enable. (#1498) d097260 Fixed compilation failure with debug option (#1518) Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-buildimage
that referenced
this pull request
Jan 14, 2021
vmittal-msft
added a commit
to vmittal-msft/sonic-buildimage
that referenced
this pull request
Oct 20, 2025
… between UT2 & LT2 (sonic-net#1518) Why I did it Updated headroom pool and per PG headroom size for cable length = 30m between UT2 & LT2 Work item tracking Microsoft ADO (34447718): sonic-net#23709 How I did it Updated MMU profiles for the same
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit addds new code for generating dynamic sai.profile file.
The sai.profile.j2 will generate the sai.profile dynamically based on
the topology. It will generate the sai.profile under /etc/sai.d/ directory
in syncd. Before syncd is started this J2 file will be run from the start.sh
file from /usr/bin/ directory. Since the sai.profile is dynamically generated
the old sai.profile file is not required so deleted the file for S6100.
It also address couple of more changes for port_config.ini support is added
for speed in the file which can be used later to find the port speed. Also
the buffer_default_t*.j2 file the ports should be from 0 to 64 changed.
Unit tested the code on S6100 for dynamic generation of sai.profile file for
both T0 and T1 and the file was created in /etc/sai.d/sai.profile
Similarly tested the sonic binary on S6000 to make sure that the sai.profile is
copied from the /usr/share/sonic/hwsku/sai.profile to /etc/sai.d/sai.profile.
Signed-off-by: Harish Venkatraman Harish_Venkatraman@dell.com
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)