Skip to content

[Base image files] All 'docker exec' wrapper scripts now dynamically adjust their flags depending on whether or not they are run on a terminal#1507

Merged
lguohan merged 1 commit intosonic-net:masterfrom
jleveque:fix_docker_exec_wrappers
Mar 17, 2018
Merged

[Base image files] All 'docker exec' wrapper scripts now dynamically adjust their flags depending on whether or not they are run on a terminal#1507
lguohan merged 1 commit intosonic-net:masterfrom
jleveque:fix_docker_exec_wrappers

Conversation

@jleveque
Copy link
Contributor

Passing -t flag to docker exec will fail if the command is being called when no on a terminal (e.g., from systemctl or cron).

This commit will dynamically add the t flag if it is determined that the command is being executed on a terminal. Otherwise, it will only pass the i (interactive) flag.

…adjust their flags depending on whether or not they are run on a terminal
@lguohan lguohan merged commit e1cb2ac into sonic-net:master Mar 17, 2018
@jleveque jleveque deleted the fix_docker_exec_wrappers branch March 17, 2018 18:38
qiluo-msft added a commit that referenced this pull request Mar 17, 2021
Included commits:
```
0d5fb48 2021-03-16 | [show] Fix 'show mac' output, when FDB entry with Vlan 1 is present (#1507) [maksymbelei95]
```
theasianpianist pushed a commit to theasianpianist/sonic-buildimage that referenced this pull request Feb 5, 2022
I re-added the copy_file method that was removed in a recent refactor.
Buildimage tests depend on this method, so subsequent submodule updates will fail.

Signed-off-by: Danny Allen <[email protected]>
mssonicbld added a commit that referenced this pull request Feb 1, 2025
…tically (#21585)

#### Why I did it
src/sonic-sairedis
```
* 77d82e82 - (HEAD -> master, origin/master, origin/HEAD) Revert "Revert back to SAI version 1 15 (#1481)" (#1507) (32 minutes ago) [prabhataravind]
```
#### How I did it
#### How to verify it
#### Description for the changelog
tshalvi pushed a commit to tshalvi/sonic-buildimage that referenced this pull request Aug 25, 2025
…AD automatically (sonic-net#1507)

#### Why I did it
src/sonic-utilities
```
* 87420914 - (HEAD -> 202412, origin/202412) Pr json support for show platform temperature (sonic-net#228) (5 hours ago) [mssonicbld]
```
#### How I did it
#### How to verify it
#### Description for the changelog
phealy added a commit to phealy/sonic-buildimage that referenced this pull request Nov 2, 2025
…rminal

Passing `-i` to docker exec will fail if stdin is not connected to a
terminal (for example: `redis-cli -n 4 --scan --pattern 'BGP_NEIGHBOR|*'
| xargs redis-cli -n 4 DEL` should delete all neighbors from the
database, but instead fails with `the input device is not a TTY`). This
adds the same dynamic detection that was added in sonic-net#1507 for stdout to
stdin.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants