table cleanup VNET_MONITOR, BFD_SESSION, ROUTE_TUNNEL#14992
Merged
prsunny merged 1 commit intosonic-net:masterfrom Jun 5, 2023
Merged
table cleanup VNET_MONITOR, BFD_SESSION, ROUTE_TUNNEL#14992prsunny merged 1 commit intosonic-net:masterfrom
prsunny merged 1 commit intosonic-net:masterfrom
Conversation
… the list of tables to be cleaned up after swss restart.
prsunny
reviewed
May 9, 2023
| $SONIC_DB_CLI GB_COUNTERS_DB FLUSHDB | ||
| $SONIC_DB_CLI RESTAPI_DB FLUSHDB | ||
| clean_up_tables STATE_DB "'PORT_TABLE*', 'MGMT_PORT_TABLE*', 'VLAN_TABLE*', 'VLAN_MEMBER_TABLE*', 'LAG_TABLE*', 'LAG_MEMBER_TABLE*', 'INTERFACE_TABLE*', 'MIRROR_SESSION*', 'VRF_TABLE*', 'FDB_TABLE*', 'FG_ROUTE_TABLE*', 'BUFFER_POOL*', 'BUFFER_PROFILE*', 'MUX_CABLE_TABLE*', 'ADVERTISE_NETWORK_TABLE*', 'VXLAN_TUNNEL_TABLE*', 'MACSEC_PORT_TABLE*', 'MACSEC_INGRESS_SA_TABLE*', 'MACSEC_EGRESS_SA_TABLE*', 'MACSEC_INGRESS_SC_TABLE*', 'MACSEC_EGRESS_SC_TABLE*', 'VRF_OBJECT_TABLE*'" | ||
| clean_up_tables STATE_DB "'PORT_TABLE*', 'MGMT_PORT_TABLE*', 'VLAN_TABLE*', 'VLAN_MEMBER_TABLE*', 'LAG_TABLE*', 'LAG_MEMBER_TABLE*', 'INTERFACE_TABLE*', 'MIRROR_SESSION*', 'VRF_TABLE*', 'FDB_TABLE*', 'FG_ROUTE_TABLE*', 'BUFFER_POOL*', 'BUFFER_PROFILE*', 'MUX_CABLE_TABLE*', 'ADVERTISE_NETWORK_TABLE*', 'VXLAN_TUNNEL_TABLE*', 'MACSEC_PORT_TABLE*', 'MACSEC_INGRESS_SA_TABLE*', 'MACSEC_EGRESS_SA_TABLE*', 'MACSEC_INGRESS_SC_TABLE*', 'MACSEC_EGRESS_SC_TABLE*', 'VRF_OBJECT_TABLE*', 'VNET_MONITOR_TABLE*', 'BFD_SESSION_TABLE*', 'VNET_ROUTE_TUNNEL_TABLE*'" |
Contributor
There was a problem hiding this comment.
Please add ADVERTISE_NETWORK_TABLE to clean-up list. Else we may see unexpected advertisements.
Contributor
Author
There was a problem hiding this comment.
its already present.
prsunny
approved these changes
May 9, 2023
Contributor
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 14992 in repo sonic-net/sonic-buildimage |
Contributor
Author
|
/azpw run Azure.sonic-buildimage |
Collaborator
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw run Azure.sonic-buildimage |
Collaborator
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw run Azure.sonic-buildimage |
Collaborator
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw run Azure.sonic-buildimage |
Collaborator
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
@siqbal1986 , do you've a PR for 202012? |
10 tasks
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Jun 15, 2023
… the list (sonic-net#14992) * The 3 tables in state DB need to be cleaned up after SWSS restart for have consistant state.
Collaborator
|
@siqbal1986 PR conflicts with 202205 branch |
Collaborator
|
Cherry-pick PR to 202211: #15490 |
10 tasks
siqbal1986
added a commit
to siqbal1986/sonic-buildimage
that referenced
this pull request
Jun 15, 2023
10 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Jun 16, 2023
… the list (#14992) * The 3 tables in state DB need to be cleaned up after SWSS restart for have consistant state.
mssonicbld
added
Included in 202211 Branch
and removed
Approved for 202211 Branch
Created PR to 202211 Branch
labels
yxieca
pushed a commit
that referenced
this pull request
Jun 16, 2023
sonic-otn
pushed a commit
to sonic-otn/sonic-buildimage
that referenced
this pull request
Sep 20, 2023
… the list (sonic-net#14992) * The 3 tables in state DB need to be cleaned up after SWSS restart for have consistant state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 3 tables in state DB need to be cleaned up after SWSS restart for have consistat state.
Why I did it
Failing to clean up these tables causes an inconsistent state.
Work item tracking
21695894
How I did it
added 3 tables in clean up script.
How to verify it
add a vnet route with monitoring. bring up the monitors. restart the swss. readd the route. THe route should not become active.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)