Third Party Container Management Support in Sonic App Extension#14917
Third Party Container Management Support in Sonic App Extension#14917Praveen-Brcm merged 1 commit intosonic-net:masterfrom
Conversation
|
During the presentation today, there was a chat message requesting review sign-ups. @prvattem from Dell can review. @zhangyanzhao can you help assign? |
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@prvattem @venkatmahalingam @stepanblyschak pls review the Code PR |
There was a problem hiding this comment.
Where is target_machine consumed in default_manifest.j2?
There was a problem hiding this comment.
target_machine is not required in default_manifest.j2
Hence removed it now.
There was a problem hiding this comment.
Why install new package?
There was a problem hiding this comment.
If required for sonic-utilities then specify in setup.py - https://github.com/sonic-net/sonic-utilities/blob/master/setup.py#L230
There was a problem hiding this comment.
I see paramiko is already present in setup.py.
Hence removed it from here now.
There was a problem hiding this comment.
This one will be listed by this command, although not created by the user and can be deleted by the user.
admin@r-moose-01:~$ sudo spm manifests list
Custom Local Manifest files:
- default_manifest
Is that expected?
There was a problem hiding this comment.
The default_manifest seems to be duplicated in sonic-utilities PR, why need in both places?
There was a problem hiding this comment.
Tab vs space inconsistency
There was a problem hiding this comment.
False -> false
True -> true
There was a problem hiding this comment.
Seems it does not require to be a Jinja template
|
This repo change is not required anymore as the changes are accommodated in sonic-utilities repo. |
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Commenter does not have sufficient privileges for PR 14917 in repo sonic-net/sonic-buildimage |
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@adyeung This sonic-buildimage repo change for TPCM support is also required as per the build time requirement change (hence reopened it) and is also approved by the Reviewer. |
6 participants
Why I did it
To support Third Party Container Management in Sonic App Extension Framework
Work item tracking
How I did it
The main changes for this feature are in sonic-utilities repo.
Here in this sonic-buildimage repo, this change is to prepare the directory (subdirectory "manifests" under /var/lib/sonic-package-manager) and the default manifest at build time without the need to create it in runtime every time
How to verify it
Execute commands specified in sonic-utilities repo PR for TPCM.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)