[system-health] When disabling a feature the SYSTEM_READY|SYSTEM_STAT…#14823
Merged
liat-grozovik merged 3 commits intosonic-net:masterfrom May 30, 2023
Merged
Conversation
Junchao-Mellanox
previously approved these changes
Apr 25, 2023
Contributor
Author
|
/azpw run Azure.sonic-buildimage |
Collaborator
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
@DavidZagury is there a GitHub issue which explain the issue and what cause it? if so, can you refer to it? |
Contributor
Author
No there is no GitHub issue opened. @sg893052 I see that you were the original author of this feature, will apricate your review |
Collaborator
|
@DavidZagury can you please resolve conflicts? |
DavidZagury
force-pushed
the
fix_feature_disable_issue
branch
from
2ad7731 to
da5737c
Compare
DavidZagury
force-pushed
the
fix_feature_disable_issue
branch
2 times, most recently
from
497e98f to
72a8807
Compare
Contributor
Author
|
@liat-grozovik conflicts resolved |
Junchao-Mellanox
previously approved these changes
May 4, 2023
Collaborator
|
@DavidZagury please handle conflicts. |
DavidZagury
force-pushed
the
fix_feature_disable_issue
branch
from
92d1690 to
72a8807
Compare
DavidZagury
force-pushed
the
fix_feature_disable_issue
branch
from
72a8807 to
9592595
Compare
Contributor
Author
|
@liat-grozovik conflicts handled |
Junchao-Mellanox
approved these changes
May 30, 2023
liat-grozovik
approved these changes
May 30, 2023
This was referenced Jun 12, 2023
sonic-otn
pushed a commit
to sonic-otn/sonic-buildimage
that referenced
this pull request
Sep 20, 2023
…E was not updated (sonic-net#14823) - Why I did it If you enable feature and then disable it, System Ready status change to Not Ready A disabled feature should not affect the system ready status. - How I did it During the disable flow of dhcp_relay, it entered the dnsrvs_name list, which caused the SYSTEM_STATE key to be set to DOWN. Right after that, the dhcp_relay service was removed from the full service list, however, but, when it was removed from the dnsrvs_name, there was no flow to reset the system state back to UP even though there was no more services in down state. - How to verify it root@qa-eth-vt01-2-3700v:/home/admin# config feature state dhcp_relay enabled root@qa-eth-vt01-2-3700v:/home/admin# show system-health sysready-status root@qa-eth-vt01-2-3700v:/home/admin# config feature state dhcp_relay disabled root@qa-eth-vt01-2-3700v:/home/admin# show system-health sysready-status Should see System is ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…E was not updated
Fix issue #14916
Why I did it
If you enable feature and then disable it, System Ready status change to Not Ready
A disabled feature should not affect the system ready status.
Work item tracking
How I did it
During the disable flow of dhcp_relay, it entered the dnsrvs_name list, which caused the SYSTEM_STATE key to be set to DOWN. Right after that, the dhcp_relay service was removed from the full service list, however, but, when it was removed from the dnsrvs_name, there was no flow to reset the system state back to UP even though there was no more services in down state.
How to verify it
Should see
System is readyWhich release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)