Merged
Conversation
Signed-off-by: Wenda <[email protected]>
Signed-off-by: Wenda <[email protected]>
lguohan
requested changes
Mar 8, 2018
Collaborator
lguohan
left a comment
lguohan
left a comment
There was a problem hiding this comment.
can you modify s6000, 7050-qx32 as well?
yxieca
reviewed
Mar 9, 2018
Contributor
yxieca
left a comment
yxieca
left a comment
There was a problem hiding this comment.
Wenda,
Can you use 7260cx3 configuration as example, use the new shared infrastructure for this configuration?
Thanks,
Ying
Contributor
Author
|
@yxieca Does the old config still work? If so, I prefer updating to the new one in a separate PR. |
Contributor
|
The old one still work. You can update in a separate PR. Cheers, |
lguohan
approved these changes
Mar 10, 2018
Contributor
|
short reminder: Use squash and merge to update the commit message and check in the commit 🍺 |
Contributor
Author
|
🍻 |
4 tasks
daall
added a commit
to daall/sonic-buildimage
that referenced
this pull request
Mar 5, 2021
- [201911][acl] Expand VLAN into VLAN members when creating an ACL table (sonic-net#1477) - [201911][acl-loader] Add support for matching on ICMP and VLAN info (sonic-net#1476) - [201911][acl-loader] Improve input validation for acl_loader (sonic-net#1481) Signed-off-by: Danny Allen <[email protected]>
lguohan
pushed a commit
that referenced
this pull request
Mar 5, 2021
- [201911][acl] Expand VLAN into VLAN members when creating an ACL table (#1477) - [201911][acl-loader] Add support for matching on ICMP and VLAN info (#1476) - [201911][acl-loader] Improve input validation for acl_loader (#1481) Signed-off-by: Danny Allen <[email protected]>
theasianpianist
pushed a commit
to theasianpianist/sonic-buildimage
that referenced
this pull request
Feb 5, 2022
patrickmacarthur
pushed a commit
to patrickmacarthur/sonic-buildimage
that referenced
this pull request
Dec 11, 2025
…iles for arista supervisors (sonic-net#1476) <!-- Please make sure you've read and understood our contributing guidelines: https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md ** Make sure all your commits include a signature generated with `git commit -s` ** If this is a bug fix, make sure your description includes "fixes #xxxx", or "closes #xxxx" or "resolves #xxxx" Please provide the following information: --> #### Why I did it Port config files are not required for arista supervisors ##### Work item tracking - Microsoft ADO **(number only)**: #### How I did it remove the empty files #### How to verify it <!-- If PR needs to be backported, then the PR must be tested against the base branch and the earliest backport release branch and provide tested image version on these two branches. For example, if the PR is requested for master, 202211 and 202012, then the requester needs to provide test results on master and 202012. --> #### Which release branch to backport (provide reason below if selected) <!-- - Note we only backport fixes to a release branch, *not* features! - Please also provide a reason for the backporting below. - e.g. - [x] 202006 --> - [ ] 202205 - [ ] 202211 - [ ] 202305 - [ ] 202311 - [x ] 202405 - [x ] 202411 - [x ] 202505 #### Tested branch (Please provide the tested image version) <!-- - Please provide tested image version - e.g. - [x] 20201231.100 --> - [ ] <!-- image version 1 --> - [ ] <!-- image version 2 --> #### Description for the changelog <!-- Write a short (one line) summary that describes the changes in this pull request for inclusion in the changelog: --> Remove empty port_config.ini files for arista supervisors <!-- Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU. --> #### Link to config_db schema for YANG module changes <!-- Provide a link to config_db schema for the table for which YANG model is defined Link should point to correct section on https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md --> #### A picture of a cute animal (not mandatory but encouraged)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Improve memory utilization and robustness to traffic burstiness through better buffer sharing at the ingress
- How I did it
Consolidate the buffer pools of PG 3 and 4.
Reduce the size of dedicated buffers per port per lossless PG to leave buffer space for shared pool.
Use dynamic threshold to absorb burstiness while maintain fairness.
- How to verify it
Verified the config on A7050-QX-32S:
Tested ingress PG pool sizing
Tested ingress xon offset
Tested ECN min threshold and max threshold
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)