SONiC Yang model support for IPv6 link local by AkhileshSamineni · Pull Request #14757 · sonic-net/sonic-buildimage

AkhileshSamineni · 2023-04-20T09:53:04Z

SONiC Yang model support for IPv6 link local

What I did
Created SONiC Yang model for IPv6 link local

How I did it
Defined Yang models for IPv6 link local based on https://github.com/sonic-net/SONiC/blob/master/doc/ipv6/ipv6_link_local.md

How to verify it
Added enable test case.

Signed-off-by: Akhilesh Samineni [email protected]

linux-foundation-easycla · 2023-04-20T09:53:07Z

The committers listed above are authorized under a signed CLA.

✅ login: AkhileshSamineni / name: Akhilesh Samineni (0e58069)

AkhileshSamineni · 2023-04-20T15:29:03Z

/azpw run Azure.sonic-buildimage

mssonicbld · 2023-04-20T15:29:05Z

/AzurePipelines run Azure.sonic-buildimage

azure-pipelines · 2023-04-20T15:29:18Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2023-04-20T15:29:39Z

Azure Pipelines successfully started running 1 pipeline(s).

ganglyu · 2023-04-21T00:27:14Z

src/sonic-yang-models/yang-models/sonic-vlan.yang


+				leaf ipv6_use_link_local_only {
+					description "Enable/Disable IPv6 link local address on vlan interface";
+					type enumeration {


How about this type?
https://github.com/sonic-net/sonic-buildimage/blob/master/src/sonic-yang-models/yang-templates/sonic-types.yang.j2#L178

ganglyu · 2023-04-21T00:29:30Z

src/sonic-yang-models/yang-models/sonic-interface.yang


+				leaf ipv6_use_link_local_only {
+					description "Enable/Disable IPv6 link local address on interface";
+					type enumeration {


https://github.com/sonic-net/sonic-buildimage/blob/master/src/sonic-yang-models/yang-templates/sonic-types.yang.j2#L178

ganglyu · 2023-04-21T00:29:37Z

src/sonic-yang-models/yang-models/sonic-portchannel.yang

+
+		leaf ipv6_use_link_local_only {
+			description "Enable/Disable IPv6 link local address on portchannel interface";
+			type enumeration {


https://github.com/sonic-net/sonic-buildimage/blob/master/src/sonic-yang-models/yang-templates/sonic-types.yang.j2#L178

dgsudharsan

Please update sample_config_db.json as well as Configuration guide.

dgsudharsan · 2023-04-21T03:19:15Z

src/sonic-yang-models/tests/yang_model_tests/tests_config/interface.json

Please try to cover one negative scenario (e.g. "ipv6_use_link_local_only": "true") where yang validation should fail

Signed-off-by: Akhilesh Samineni <[email protected]>

dgsudharsan · 2023-04-23T01:10:04Z

@AkhileshSamineni Can you please update sample_config_db.json and Configuration schema?

Signed-off-by: Akhilesh Samineni <[email protected]>

AkhileshSamineni · 2023-04-23T04:34:39Z

@AkhileshSamineni Can you please update sample_config_db.json and Configuration schema?

Done.

AkhileshSamineni · 2023-04-26T16:09:39Z

@qiluo-msft Test failure is not related to code changes. Trying the re-build again.

AkhileshSamineni · 2023-04-26T16:10:01Z

/azpw run Azure.sonic-buildimage

mssonicbld · 2023-04-26T16:10:03Z

/AzurePipelines run Azure.sonic-buildimage

mssonicbld · 2023-04-28T15:37:10Z

/AzurePipelines run Azure.sonic-buildimage

azure-pipelines · 2023-04-28T15:37:20Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2023-05-08T17:19:02Z

@AkhileshSamineni PR conflicts with 202205 branch

mssonicbld · 2023-05-08T17:19:06Z

@AkhileshSamineni PR conflicts with 202111 branch

moshemos · 2023-05-10T13:38:43Z

@AkhileshSamineni can you fix the conflict both for 202205 as well as 202211? please priorities

mssonicbld · 2023-05-12T03:20:04Z

@AkhileshSamineni PR conflicts with 202211 branch

This is backport of #14757 SONiC Yang model support for IPv6 link local What I did Created SONiC Yang model for IPv6 link local How I did it Defined Yang models for IPv6 link local based on https://github.com/sonic-net/SONiC/blob/master/doc/ipv6/ipv6_link_local.md How to verify it Added enable test case. Signed-off-by: Akhilesh Samineni [email protected]

…#14757)

dgsudharsan · 2023-05-19T18:33:37Z

@AkhileshSamineni Can you please create cherry-pick PR for 202205 as well?

This is backport of #14757 SONiC Yang model support for IPv6 link local What I did Created SONiC Yang model for IPv6 link local How I did it Defined Yang models for IPv6 link local based on https://github.com/sonic-net/SONiC/blob/master/doc/ipv6/ipv6_link_local.md How to verify it Added enable test case. Signed-off-by: Akhilesh Samineni <[email protected]>

keboliu · 2023-06-13T01:47:32Z

update the label since it has been included in 202211 through PR #15021

This is backport of sonic-net#14757 SONiC Yang model support for IPv6 link local What I did Created SONiC Yang model for IPv6 link local How I did it Defined Yang models for IPv6 link local based on https://github.com/sonic-net/SONiC/blob/master/doc/ipv6/ipv6_link_local.md How to verify it Added enable test case. Signed-off-by: Akhilesh Samineni <[email protected]>

wen587 · 2025-02-24T03:01:09Z

Hi @AkhileshSamineni , could you check if it is miss that not consider sub interface case?
#21631

SONiC Yang model support for IPv6 link local

0e58069

Signed-off-by: Akhilesh Samineni [email protected]

AkhileshSamineni requested a review from qiluo-msft as a code owner April 20, 2023 09:53

AkhileshSamineni mentioned this pull request Apr 20, 2023

[yang] interface yang model is missing ipv6_use_link_local_only key #14493

Closed

zhangyanzhao requested a review from dgsudharsan April 20, 2023 17:56

qiluo-msft requested review from ganglyu and removed request for dgsudharsan April 20, 2023 17:56

qiluo-msft added the YANG YANG model related changes label Apr 20, 2023

ganglyu reviewed Apr 21, 2023

View reviewed changes

dgsudharsan requested changes Apr 21, 2023

View reviewed changes

dgsudharsan added the Request for 202211 Branch label Apr 21, 2023

dgsudharsan requested changes Apr 21, 2023

View reviewed changes

AkhileshSamineni added 3 commits April 22, 2023 01:31

Addressed review comments.

355cb2b

Signed-off-by: Akhilesh Samineni <[email protected]>

Addressed review comments1.

de20a88

Signed-off-by: Akhilesh Samineni <[email protected]>

Fixed build error.

8d86d62

Signed-off-by: Akhilesh Samineni <[email protected]>

ganglyu previously approved these changes Apr 23, 2023

View reviewed changes

Updated sample_config_db.json and Configuration schema.

4d08ac7

Signed-off-by: Akhilesh Samineni <[email protected]>

AkhileshSamineni dismissed ganglyu’s stale review via 4d08ac7 April 23, 2023 04:34

dgsudharsan approved these changes Apr 24, 2023

View reviewed changes

dgsudharsan added the Request for 202205 Branch label May 2, 2023

qiluo-msft approved these changes May 4, 2023

View reviewed changes

qiluo-msft merged commit 9e2b181 into sonic-net:master May 4, 2023

yxieca added Approved for 202111 Branch Approved for 202205 Branch labels May 8, 2023

mssonicbld added the Cherry Pick Conflict_202205 label May 8, 2023

mssonicbld added the Cherry Pick Conflict_202111 label May 8, 2023

liat-grozovik mentioned this pull request May 11, 2023

SONiC Yang model support for IPv6 link local (#14757) #15021

Merged

StormLiangMS added the Approved for 202211 Branch label May 12, 2023

mssonicbld added the Cherry Pick Conflict_202211 label May 12, 2023

keboliu added a commit to keboliu/sonic-buildimage that referenced this pull request May 12, 2023

[202211_RC13] SONiC Yang model support for IPv6 link local (sonic-net…

a414ff1

…#14757)

AkhileshSamineni mentioned this pull request May 22, 2023

SONiC Yang model support for IPv6 link local (#14757) #15182

Merged

yxieca added the Included in 202205 Branch label May 26, 2023

keboliu added Included in 202211 Branch and removed Approved for 202211 Branch Cherry Pick Conflict_202211 labels Jun 13, 2023

wen587 mentioned this pull request Feb 17, 2025

yang(sonic-interface): name of value "Ethernet0.666" points to a non-existing leaf #21631

Open

Conversation

AkhileshSamineni commented Apr 20, 2023

Uh oh!

linux-foundation-easycla bot commented Apr 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AkhileshSamineni commented Apr 20, 2023

Uh oh!

mssonicbld commented Apr 20, 2023

Uh oh!

azure-pipelines bot commented Apr 20, 2023

Uh oh!

azure-pipelines bot commented Apr 20, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dgsudharsan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dgsudharsan commented Apr 23, 2023

Uh oh!

AkhileshSamineni commented Apr 23, 2023

Uh oh!

AkhileshSamineni commented Apr 26, 2023

Uh oh!

AkhileshSamineni commented Apr 26, 2023

Uh oh!

mssonicbld commented Apr 26, 2023

Uh oh!

mssonicbld commented Apr 28, 2023

Uh oh!

azure-pipelines bot commented Apr 28, 2023

Uh oh!

mssonicbld commented May 8, 2023

Uh oh!

mssonicbld commented May 8, 2023

Uh oh!

moshemos commented May 10, 2023

Uh oh!

mssonicbld commented May 12, 2023

Uh oh!

dgsudharsan commented May 19, 2023

Uh oh!

keboliu commented Jun 13, 2023

Uh oh!

wen587 commented Feb 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

linux-foundation-easycla bot commented Apr 20, 2023 •

edited

Loading